From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Date: Thu, 13 Jan 2022 09:46:31 +0100 Message-ID: <878rvk3tw8.fsf@gmail.com> References: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37952"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Kangas , emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 13 09:47:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n7vle-0009fA-UB for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 09:47:34 +0100 Original-Received: from localhost ([::1]:42532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7vld-0007HH-BP for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jan 2022 03:47:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7vki-0006Ft-8S for emacs-devel@gnu.org; Thu, 13 Jan 2022 03:46:36 -0500 Original-Received: from [2a00:1450:4864:20::431] (port=38663 helo=mail-wr1-x431.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7vkg-0000vB-KK; Thu, 13 Jan 2022 03:46:35 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id a5so8758156wrh.5; Thu, 13 Jan 2022 00:46:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=j6/lGjCpPqLSypf52a9gGXrk+QqSRRBbMFA2g4lcx1U=; b=P2QOv7sIw5LGLSGa4oWltoBJwle7ydWW01C2W3RoMmsstQAmps4sVSnlZGcScv4hll zYOWf6RN2Zrw5cvccqv/hCmurHlPXoaWvW1m5ncD5QIr1qB7mtYg3zNuGT+eqQjxm7Nk VaPRZ0duss/i5Z0fCEKDp8oDJnVWJGD3kt76BNGW6O8KyXWs28Eh+C7woy2DdQHyJ9BF g6MkGJi/yvqcJUTStHXRwmV7pyxEPg/EbfROX2SDlAmyMPjw8RPtp3EyPbfjrjIIB0hq GFHaUrYNvny1ok/ES9yDZ1DuODb1ZGTUo7ux5XOuZzYw05HMTdwtYktrEBkFcqRkEI5a nWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=j6/lGjCpPqLSypf52a9gGXrk+QqSRRBbMFA2g4lcx1U=; b=U4epr7N98SekkK74UtXtE50CrHfb/4AeU3XlT4Q7RrP/+QXJu43Bk6QBVUueg8sKAv +GPyBxO0jABkH61TNL9PviqLV6gtVs55BuYA1a9SNKi8MTcKb0xZECK+2F6PeVrGwt0b +aZ/JYPxqYhFqe4GLcrjayMe5C4gono2GhAa233Nx6Q5IJDOi/Xh4v5HnA2venyzDikX DzqytmvVyeIQYKdo1AB6KerQq5bSLz9njh632K3HU9o4Huf7vwIQqcQKZXN+I1BQ6LBV 2jAJ/URw7eZDUXgGbexChxP9GbOLDRCix4PsmruA/dPvpBdUxUk/zTEvUH50MNSRG3gY GIog== X-Gm-Message-State: AOAM53205ZMVUiH5RKnxsC/kamoSdYg/iti/PWITO4mz+WhVqnYwP6gf jjW+yXjUUht+q1xdcu7Kc9dyUeH3Ty8= X-Google-Smtp-Source: ABdhPJzibzvvSP9XQdkCqnwSArrERc+GeCqGgr8zPh6vif9r31nyCog6roaVFVyt/XU5zJdbO0D9xg== X-Received: by 2002:a5d:5310:: with SMTP id e16mr3026290wrv.402.1642063592568; Thu, 13 Jan 2022 00:46:32 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:da2c:6e12:f0db:3a30]) by smtp.gmail.com with ESMTPSA id i6sm2330771wrf.79.2022.01.13.00.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 00:46:31 -0800 (PST) In-Reply-To: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> (Phil Sainty's message of "Thu, 13 Jan 2022 20:51:50 +1300") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::431 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=rpluim@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:284687 Archived-At: >>>>> On Thu, 13 Jan 2022 20:51:50 +1300, Phil Sainty said: Phil> Eli Zaretskii wrote: >> > From: Robert Pluim >> > Debugger entered--Lisp error: (error "Can't find Hunspell dictiona= ry with a >> > .aff affix f...") >> > signal(error ("Can't find Hunspell dictionary with a .aff affix = f...")) >> > error("Can't find Hunspell dictionary with a .aff affix f...") >> > ispell-find-hunspell-dictionaries() >> > ispell-set-spellchecker-params() >> > ispell-valid-dictionary-list() >> > >> > This is because I have no hunspell dictionaries at all >> So you want to fix this? I don't mind, but since it's (AFAIU) >> something specific to your installation, is it important to fix on >> the release branch? Phil> While unexpected, it doesn't seem *invalid* to have no dictionari= es Phil> installed, so I think it's weird that `ispell-valid-dictionary-li= st' Phil> triggers (indirectly) an error in this scenario to essentially say Phil> "there were no valid dictionaries", when that's also what a nil r= eturn Phil> value would have meant. Phil> `ispell-valid-dictionary-list' or `ispell-set-spellchecker-params' Phil> should perhaps use `with-demoted-errors' to avoid this? Perhaps Phil> Failing that, I think guarding against this in spelling-tests.el = with Phil> `ignore-errors' makes sense. It's an :unstable test, but it shou= ldn't Phil> be triggering actual errors. It=CA=BCs not the test that=CA=BCs triggering errors, it=CA=BCs the check t= o see if the test should be defined at all. I=CA=BCll take a look at fixing that and ispell-valid-dictionary-list on master. Robert --=20