From: Robert Pluim <rpluim@gmail.com>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefan@marxist.se>,
emacs-devel@gnu.org
Subject: Re: "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out)
Date: Thu, 13 Jan 2022 09:46:31 +0100 [thread overview]
Message-ID: <878rvk3tw8.fsf@gmail.com> (raw)
In-Reply-To: <5c74e0fb4c651733c0d8072f7cd40d06@webmail.orcon.net.nz> (Phil Sainty's message of "Thu, 13 Jan 2022 20:51:50 +1300")
>>>>> On Thu, 13 Jan 2022 20:51:50 +1300, Phil Sainty <psainty@orcon.net.nz> said:
Phil> Eli Zaretskii <eliz@gnu.org> wrote:
>> > From: Robert Pluim <rpluim@gmail.com>
>> > Debugger entered--Lisp error: (error "Can't find Hunspell dictionary with a
>> > .aff affix f...")
>> > signal(error ("Can't find Hunspell dictionary with a .aff affix f..."))
>> > error("Can't find Hunspell dictionary with a .aff affix f...")
>> > ispell-find-hunspell-dictionaries()
>> > ispell-set-spellchecker-params()
>> > ispell-valid-dictionary-list()
>> >
>> > This is because I have no hunspell dictionaries at all
>> So you want to fix this? I don't mind, but since it's (AFAIU)
>> something specific to your installation, is it important to fix on
>> the release branch?
Phil> While unexpected, it doesn't seem *invalid* to have no dictionaries
Phil> installed, so I think it's weird that `ispell-valid-dictionary-list'
Phil> triggers (indirectly) an error in this scenario to essentially say
Phil> "there were no valid dictionaries", when that's also what a nil return
Phil> value would have meant.
Phil> `ispell-valid-dictionary-list' or `ispell-set-spellchecker-params'
Phil> should perhaps use `with-demoted-errors' to avoid this?
Perhaps
Phil> Failing that, I think guarding against this in spelling-tests.el with
Phil> `ignore-errors' makes sense. It's an :unstable test, but it shouldn't
Phil> be triggering actual errors.
Itʼs not the test thatʼs triggering errors, itʼs the check to see if
the test should be defined at all. Iʼll take a look at fixing that and
ispell-valid-dictionary-list on master.
Robert
--
next prev parent reply other threads:[~2022-01-13 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 7:51 "Can't find Hunspell dictionary" error (was Re: Emacs pretest 28.0.91 is out) Phil Sainty
2022-01-13 8:46 ` Robert Pluim [this message]
2022-01-13 10:20 ` Robert Pluim
2022-01-13 10:39 ` Eli Zaretskii
2022-01-13 11:28 ` Phil Sainty
2022-01-13 12:39 ` Eli Zaretskii
2022-01-13 14:05 ` Robert Pluim
2022-01-13 14:42 ` Eli Zaretskii
2022-01-14 1:05 ` Phil Sainty
2022-01-14 7:12 ` Eli Zaretskii
2022-01-14 9:06 ` Phil Sainty
2022-01-14 12:02 ` Eli Zaretskii
2022-01-13 11:26 ` Phil Sainty
2022-01-13 14:23 ` Robert Pluim
2022-01-13 14:38 ` Robert Pluim
2022-01-13 11:57 ` Phil Sainty
2022-01-13 14:30 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rvk3tw8.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=psainty@orcon.net.nz \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).