unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: dalanicolai <dalanicolai@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: (doc-view.el) Tabs or spaces convention?
Date: Wed, 19 Jan 2022 15:03:45 +0100	[thread overview]
Message-ID: <878rvbom9q.fsf@gmail.com> (raw)
In-Reply-To: <CACJP=3kYRxgQ=1zXVtYzox5V7iRcZAxUqW0a3LNj_QTjrV11aw@mail.gmail.com> (dalanicolai@gmail.com's message of "Wed, 19 Jan 2022 14:22:48 +0100")

>>>>> On Wed, 19 Jan 2022 14:22:48 +0100, dalanicolai <dalanicolai@gmail.com> said:

    dalanicolai> It seems that doc-view.el is (still) full of tabs (I only discovered when I
    dalanicolai> wanted to make a commit,
    dalanicolai> and git errored).

I think the Emacs git hooks only trigger on trailing whitespace, but
of course git also checks stuff like that.

    dalanicolai> I will just convert all tabs to spaces unless that would
    dalanicolai> make me deviate from
    dalanicolai> some 'hidden' convention. In that case, please inform me about it. I wasn't
    dalanicolai> able to find any info
    dalanicolai> about it.

If itʼs on lines that youʼre changing anyway, itʼs not an issue, just
donʼt mass replace tabs with spaces in the whole file.

Robert
-- 



  reply	other threads:[~2022-01-19 14:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 13:22 (doc-view.el) Tabs or spaces convention? dalanicolai
2022-01-19 14:03 ` Robert Pluim [this message]
2022-01-19 14:41 ` Stefan Monnier
2022-01-19 21:41   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rvbom9q.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=dalanicolai@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).