From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Mon, 07 Mar 2022 13:03:16 -0600 Message-ID: <878rtl1t6z.fsf@red-bean.com> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> <837d99j10x.fsf@gnu.org> <874k4dlpeg.fsf@elite.giraud> <834k4divrt.fsf@gnu.org> <87wnh9k43g.fsf@elite.giraud> <83v8wth5lh.fsf@gnu.org> <87h78afndq.fsf@red-bean.com> <83r17dgb3d.fsf@gnu.org> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26571"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 07 20:04:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRIeK-0006bC-Iz for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 20:04:04 +0100 Original-Received: from localhost ([::1]:51090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRIeJ-0000GS-Bt for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Mar 2022 14:04:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRIdf-00080n-2S for emacs-devel@gnu.org; Mon, 07 Mar 2022 14:03:23 -0500 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:55642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRIdd-0003sU-3h; Mon, 07 Mar 2022 14:03:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:Reply-To:References:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jqWPeUJeNR9tL2CSc7Axm9Wi2eU3C6wP4c7TYX5UDr4=; t=1646679800; x=1647889400; b=CZxXZf47u7lidc6xvmhEYCh0VJncFbXyvSFBLf0xgnU/q+59ARPB5CqYQOz+rhsJfDyBsvUF3Ab 2iaQkxEjHom4o+89k2qzyOVUPAFMTWgjO42F9kCxZkDcreVvmXYZTVlkGUKckySKZVgLtKUEpnZ/l g4ErS/oKfoy11JQKhe2uvU0s9HH2h+jdnNy7l7dBUL1ZrGoroj3Lw86qsiv/1RtrWMTzhsnww/3H5 0St9OxxQg1MuRS6XDLgZRroJpr//6CwZCrKntVrSJNObvB+2eRmLZkG2lx8ef5OowOq0xM9+g5OTZ r1g8/2iC0TM/EFTuQPzDp85mgPIfmkJjvFEg==; Original-Received: from [2601:240:c400:76::9d04] (port=53090 helo=klen) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRIdY-00FL0Q-U4; Mon, 07 Mar 2022 19:03:18 +0000 In-Reply-To: <83r17dgb3d.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar 2022 15:12:54 +0200") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286899 Archived-At: On 07 Mar 2022, Eli Zaretskii wrote: >> --- lisp/bookmark.el >> +++ lisp/bookmark.el >> @@ -246,11 +246,13 @@ bookmark-alist >> Bookmark functions update the value automatically. >> You probably do NOT want to change the value yourself. >> >> -The value is an alist with bookmarks of the form >> +The value is an alist whose elements are the form > ^^^^^^^^^^^^^^^^^^^^^ >"...elements are of the form", right? Good catch! Thank you. >These are documentation changes, so if you like, you can install >them >on the emacs-28 branch. Will do (with the above correction). >> From: Karl Fogel >> Date: Sun, 6 Mar 2022 21:20:34 -0600 >> Subject: [PATCH] Ensure bookmark bmenu buffer sorts when it >> should >> >> * lisp/bookmark.el (bookmark-bmenu--revert): Check >> `bookmark-sort-flag' >> every time when displaying bookmarks. >> >> [...] >This one is still under debate (or at least incomplete), AFAIU. Yes; I'll repost another patch addressing Manuel's point about the tabulated-list bar (thanks, Manuel), and then we can decide where to put it. Best regards, -Karl