From: Karl Fogel <kfogel@red-bean.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: manuel@ledu-giraud.fr, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting.
Date: Mon, 07 Mar 2022 13:03:16 -0600 [thread overview]
Message-ID: <878rtl1t6z.fsf@red-bean.com> (raw)
In-Reply-To: <83r17dgb3d.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar 2022 15:12:54 +0200")
On 07 Mar 2022, Eli Zaretskii wrote:
>> --- lisp/bookmark.el
>> +++ lisp/bookmark.el
>> @@ -246,11 +246,13 @@ bookmark-alist
>> Bookmark functions update the value automatically.
>> You probably do NOT want to change the value yourself.
>>
>> -The value is an alist with bookmarks of the form
>> +The value is an alist whose elements are the form
> ^^^^^^^^^^^^^^^^^^^^^
>"...elements are of the form", right?
Good catch! Thank you.
>These are documentation changes, so if you like, you can install
>them
>on the emacs-28 branch.
Will do (with the above correction).
>> From: Karl Fogel <kfogel@red-bean.com>
>> Date: Sun, 6 Mar 2022 21:20:34 -0600
>> Subject: [PATCH] Ensure bookmark bmenu buffer sorts when it
>> should
>>
>> * lisp/bookmark.el (bookmark-bmenu--revert): Check
>> `bookmark-sort-flag'
>> every time when displaying bookmarks.
>>
>> [...]
>This one is still under debate (or at least incomplete), AFAIU.
Yes; I'll repost another patch addressing Manuel's point about the
tabulated-list bar (thanks, Manuel), and then we can decide where
to put it.
Best regards,
-Karl
next prev parent reply other threads:[~2022-03-07 19:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:39 [PATCH] Fix bookmark-bmenu-list sorting Manuel Giraud
2022-03-03 17:41 ` Karl Fogel
2022-03-03 18:19 ` Eli Zaretskii
2022-03-04 3:13 ` Karl Fogel
2022-03-04 7:14 ` Eli Zaretskii
2022-03-04 8:18 ` Karl Fogel
2022-03-04 11:46 ` Eli Zaretskii
2022-03-04 13:25 ` Manuel Giraud
2022-03-04 13:33 ` Eli Zaretskii
2022-03-04 15:15 ` Manuel Giraud
2022-03-04 15:26 ` Eli Zaretskii
2022-03-04 17:41 ` Manuel Giraud
2022-03-04 19:37 ` Eli Zaretskii
2022-03-07 3:32 ` Karl Fogel
2022-03-07 9:21 ` Manuel Giraud
2022-03-20 23:40 ` Karl Fogel
2022-03-21 7:54 ` Manuel Giraud
2022-03-21 14:14 ` Karl Fogel
2022-04-20 18:09 ` [PATCH] Improve sorting in the bookmark list buffer Karl Fogel
2022-04-20 19:02 ` Eli Zaretskii
2022-04-20 19:49 ` Karl Fogel
2022-04-24 17:30 ` Karl Fogel
2022-04-24 18:13 ` Eli Zaretskii
2022-04-24 19:10 ` Karl Fogel
2022-04-25 9:35 ` Manuel Giraud
2022-04-25 17:50 ` Karl Fogel
2022-04-26 7:51 ` Manuel Giraud
2022-03-07 13:12 ` [PATCH] Fix bookmark-bmenu-list sorting Eli Zaretskii
2022-03-07 19:03 ` Karl Fogel [this message]
2022-03-07 5:17 ` Karl Fogel
2022-03-04 8:34 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rtl1t6z.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).