From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] completions-max-height Date: Tue, 08 Mar 2022 08:47:13 +0000 Message-ID: <878rtk3k6m.fsf@posteo.net> References: <20220307210740.veiocemir46mmerk.ref@Ergus> <20220307210740.veiocemir46mmerk@Ergus> <87v8wpxvkj.fsf@posteo.net> <87fsntvxg6.fsf@protesilaos.com> <3723C952-ECE7-467B-AE89-73EB0819B7F0@aol.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 08 09:48:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRVWF-0002Iz-1C for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 09:48:35 +0100 Original-Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRVWD-0003Aj-BX for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 03:48:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRVV1-0002RB-59 for emacs-devel@gnu.org; Tue, 08 Mar 2022 03:47:19 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:55823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRVUz-00031v-3M for emacs-devel@gnu.org; Tue, 08 Mar 2022 03:47:18 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0BA7D240029 for ; Tue, 8 Mar 2022 09:47:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1646729235; bh=25ptwbQuhlLCVsuMDNMOAs0Dvy8QCth36gpbH/YOaM8=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=V57AjyrAXXAvdNpJVHGLNuvZD2yhcpttH/bc3jsy4N8ywcpyn26q4kbgzt+eDelGp duDsjqv5CC4nvE9W7ysIqSbr2GGmbEHFKrRDlJawCf2DjTkrwbptb9Hf8pY5gSyipH QakOFdhgFnH+adyhU6tZusL+Q7BlHx0MRfRLFt/HrouJ18pcpWhDtxFIcv+oySGJZP 1+CRl7t1UXCWU/wnM3bWUq2uKejOn3dtDtbKBNteQmYIR4vT6MioHTbIlpoe3s84eh qyrEjl/a2zSVTBTLcKAoiC93Dz8mNx3NLUuEZbr/JRBmPH1ZVwluK0zRnquFVCJz0E 1V2qNQEZ4ZCjg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KCTTt1nPgz6tm6; Tue, 8 Mar 2022 09:47:14 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <3723C952-ECE7-467B-AE89-73EB0819B7F0@aol.com> (Ergus's message of "Tue, 08 Mar 2022 09:05:29 +0100") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286918 Archived-At: Ergus writes: > I understand your intention, but in practice making this more complex > is useless. The mini buffer is always down and making the completions > to move somewhere else is uncomfortable and may require more > lisp/emacs knowledge to change the default behavior from the > user. Which is completely the opposite to my intention. Actually this > same result may be reached with an advise as I discussed on yesterday > on emacs help. But a simple custom is better. > > I am totally fine if you propose something else more general if that don't forces the user to write a function to change a simple height. What I proposed would just require something like (setq completion-display-buffer-option '(display-buffer-at-bottom (window-height . 10))) > On March 8, 2022 6:13:13 AM GMT+01:00, Protesilaos Stavrou wrote: >>On 2022-03-07, 22:10 +0000, Philip Kaludercic wrote: >> >>> Ergus writes: >>> >>>> Hi: >>>> >>>> Do you think that this may be added to vanilla? >>> >>> IMO it would be better if this could be generalised to something like >>> completion-display-buffer-action, so that you can decide where and how >>> the completion buffer is displayed. Though I am uncertain if this might >>> have unintended side effects, as the behaviour seems to have been >>> hard-coded for a while. >> >>I agree with Philip. Or go a step further and just let the Completions >>behave like other buffers so the user can contol its placement and >>parameters via the display-buffer-alist. You can do so now too, but I don't think that that would be an argument to just have the completion buffer behave like other buffers, considering that there are certainly many who are used to its current behaviour. >>-- >>Protesilaos Stavrou >>https://protesilaos.com >> -- Philip Kaludercic