Re: master b4f504a0ea: Load desktop without prompting if process is dead

Re: master b4f504a0ea: Load desktop without prompting if process is dead

[Eli Zaretskii]

> +(defun desktop--emacs-pid-running-p (pid)
> +  "Return t if an Emacs process with PID exists."
> +  (when-let ((attr (process-attributes pid)))
> +    (equal (alist-get 'comm attr)
> +           (file-name-nondirectory (car command-line-args)))))

This assumes that command-line-args resolves symlinks in the Emacs
program's name?  Or that the 'comm' attribute in process-attributes
does NOT resolve symlinks?  Because otherwise the above will cause
false negatives.  And on Windows, there's the issue of the ".exe"
extension, which could be in one, but not the other, I think?

Re: master b4f504a0ea: Load desktop without prompting if process is dead

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> This assumes that command-line-args resolves symlinks in the Emacs
> program's name?  Or that the 'comm' attribute in process-attributes
> does NOT resolve symlinks?  Because otherwise the above will cause
> false negatives.

It's a heuristic -- I don't think there's any real way to reliably find
other running Emacs processes.  They could be called anything.  But
it'll work in the default case, which is what matters here, I think.

> And on Windows, there's the issue of the ".exe"
> extension, which could be in one, but not the other, I think?

Yes, perhaps that should be adjusted.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master b4f504a0ea: Load desktop without prompting if process is dead

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacs-devel@gnu.org
> Date: Fri, 25 Mar 2022 16:28:30 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This assumes that command-line-args resolves symlinks in the Emacs
> > program's name?  Or that the 'comm' attribute in process-attributes
> > does NOT resolve symlinks?  Because otherwise the above will cause
> > false negatives.
> 
> It's a heuristic -- I don't think there's any real way to reliably find
> other running Emacs processes.  They could be called anything.  But
> it'll work in the default case, which is what matters here, I think.
> 
> > And on Windows, there's the issue of the ".exe"
> > extension, which could be in one, but not the other, I think?
> 
> Yes, perhaps that should be adjusted.

I installed a fix, please take a look.

Re: master b4f504a0ea: Load desktop without prompting if process is dead

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I installed a fix, please take a look.

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no