From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Sun, 27 Mar 2022 20:57:23 -0700 Message-ID: <878rsuvie4.fsf@ericabrahamsen.net> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> <87ilrzuoof.fsf@ericabrahamsen.net> <87ilrz9d2x.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9949"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jai Flack Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 28 05:58:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYgWV-0002Ou-Qj for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Mar 2022 05:58:31 +0200 Original-Received: from localhost ([::1]:35564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYgWU-0000lM-DI for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 23:58:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYgVV-0008SR-4R for emacs-devel@gnu.org; Sun, 27 Mar 2022 23:57:29 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:40836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYgVT-0000AK-F7 for emacs-devel@gnu.org; Sun, 27 Mar 2022 23:57:28 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 2CF15FA0B2; Mon, 28 Mar 2022 03:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1648439845; bh=a+lXmn7HGVhjAj5E5TlHj7dICqIT+oDtImNrKHmC3ss=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=P1F3VqnWFiNRHyNyNMSALWVbWoJ5loLQYT3onINgmqjNnrIRPSxBe7o2ojg/eBDbz tBaxsdoxhlz2qKKewbEWswfsvy/W2IsCjlKOs8C30R8DvMMmNoWobMMi0qMsxmI80M ZL8mjaOkGAfzCuNDqiJ1HT5+Xy0H49yXUgHO4X8Y= In-Reply-To: <87ilrz9d2x.fsf@disroot.org> (Jai Flack's message of "Mon, 28 Mar 2022 09:43:02 +1000") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287517 Archived-At: On 03/28/22 09:43 AM, Jai Flack wrote: > Eric Abrahamsen writes: > >> Jai Flack writes: >> >>> Eric Abrahamsen writes: >>> >>>> Jai Flack writes: >>>> >>>>> Eric Abrahamsen writes: >>>>>> Hi! Thanks very much for working on this. Wouldn't it make more sense to >>>>>> include this in Emacs proper? Gnus-search is new enough that it doesn't >>>>>> seem useful to let users of prior Emacs versions to install >>>>>> gnus-search-mu from the repos... What do you think? >>>>> >>>>> I'm happy for it to be included in Emacs proper; though possibly as both >>>>> a la modus-themes as it's missed the release window for Emacs 28 (if I >>>>> understand the release cycle correctly). >>>>> >>>>> Shall I convert this to a patch for gnus-search.el? >>>> >>>> Sure! Thanks. >>>> >>>> Otherwise, please make sure that the first line of docstrings are a >>>> complete sentence, and there's no need for a blank line between the >>>> first sentence and whatever comes after. >>> >>> Right. > > Were there any docstrings in particular you noticed that didn't make up > a complete sentence? I've updated them to be (roughly) the same as the > notmuch and namazu backends but the first lines already matched. Sorry, that was poorly phrased. I meant the first sentence of the docstring should all fit on a single line. Like this: (defcustom gnus-search-mu-raw-queries-p nil "If t, all mu engines will only accept raw search query strings. This can also be set per-server." :type 'boolean :group 'gnus-search) The first sentence should be munged until it doesn't wrap, then the second blank line doesn't need to be there. A la the "Tips for Documentation Strings" section of the Elisp manual. (If gnus-search.el itself doesn't fully adhere to these conventions, well... I'll get there eventually.) >>>> Out of curiosity, what is `ansi-color-filter-apply' doing there? >>> >>> I think I had trouble with mu giving ANSI escape codes to Emacs, it >>> might no longer be a problem or maybe there is a better solution. >> >> Okay, sounds good! ansi-color is built in so there's no harm in that. > > I've changed this to use the --nocolor option for mu. Even better. >> I'm assuming you have done copyright assignment. Do you have push >> permissions for ELPA and/or Emacs proper? > > Done copyright assignment. Don't have any push permissions. Are you expecting to ask for permission? (I'm not able to grant it.) If not, I can push these things for you. > For the ELPA package is there a good way to signal to users that the > built-in version should be used on a recent-enough Emacs version? I think your current Package-Requires header is the best we can do. I haven't actually tested if it will refuse to install on Emacs < 28.1, but I think due diligence is done. Eric