From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Other details about completion. Date: Mon, 04 Apr 2022 20:31:24 +0000 Message-ID: <878rsky4ir.fsf@posteo.net> References: <20220401153839.idrzrbfl2yfzga3y.ref@Ergus> <20220401153839.idrzrbfl2yfzga3y@Ergus> <86r16g92v5.fsf@mail.linkov.net> <20220401202425.jfrwqmkm3ffmcm5h@Ergus> <20220404193501.adojhz7uvvaoq4sj@Ergus> <86czhw4oqr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ergus , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 04 22:32:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbTNU-0006zm-3o for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 22:32:44 +0200 Original-Received: from localhost ([::1]:40868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbTNS-0008IE-Li for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 16:32:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbTMT-0007CD-UD for emacs-devel@gnu.org; Mon, 04 Apr 2022 16:31:41 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:57401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbTMR-00039w-Ng for emacs-devel@gnu.org; Mon, 04 Apr 2022 16:31:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 45E8E240109 for ; Mon, 4 Apr 2022 22:31:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1649104296; bh=sQqX838pg2FunszYaTmd1b+lqWyQn7F4QYYXJP8kU98=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=kLioZgAEw8rR0Yft7N2DtKkMoyo1UaOgIE+VJ7GM4vg0edFDK7ddCUUgGeZxpdWc0 opw43FiJmaqGciESmSpwwbiEhiFPbQYmqbB+j6xCDTzx6ymru0p4NHSlJdQm6ujHX4 KeulhnkaMtQlgiVq1vjS/Bbu2TGlVUSSpMnX3r82H9lvNHRTxFmg8dck6KD46/qwPU 4NR5b3dqjTbfUikDemkSm+FxsawTCMLddN6w0uzHA/JwmojS9NHLXjkxlChq7QkLmZ qjVcjPshXPXaJvBFDbUy1y4t+5lXGuDUNIQOTzU+aC8VhDxdtZfulczSTtS1tirEEw gTz2UhZWF5HwQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KXMr74F6Hz6tmd; Mon, 4 Apr 2022 22:31:35 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <86czhw4oqr.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 04 Apr 2022 22:45:00 +0300") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287778 Archived-At: Juri Linkov writes: >> May I finally add this patch to master?? > > I don't know, maybe Philip has no time to review your patch? Sorry about that (I was struck down with Corona for the last few days, so I forgot to respond). Either way, I don't have any objections (beyond what was discussed in bug#54374 that it might be a good idea to rethink that mouse-face approach in general -- but if change 2) solves this then the issue isn't that urgent). >> On Fri, Apr 01, 2022 at 10:24:25PM +0200, Ergus wrote: >>>Hi again... >>> >>>Here I attached a small patch that makes 3 small changes: >>> >>>1) Remove the trailing newline in completions one-column >>>2) Use another condition in next-completion to jump to minibuffer. >>> >>>Normally next-completion with tabs at the end of the buffer needs an >>>extra tab because it goes to the end of the last completion before >>>jumping to the minibuffer or wrap.. That extra tab is because the >>>condition to jump or wrap was eobp/bobp assuming that there is not text >>>unproppertized after the last candidate. >>> >>>3) Remove a comment in switch-to-completions. That comment suggested that >>>the next-completion action must be called inside >>>minibuffer-completion-help but IMO that is not totally correct when >>>completion-auto-select has some of the new values. >>> >>>Please, if anyone could review,correct and push I would be very >>>grateful. -- Philip Kaludercic