From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 5141234acf: Refactor the webp cache code to allow usage by gif_load, too Date: Mon, 11 Apr 2022 14:44:23 +0200 Message-ID: <878rsbbxi0.fsf@gnus.org> References: <164967696186.12152.11548736665906939483@vcs2.savannah.gnu.org> <20220411113602.7A114C0581E@vcs2.savannah.gnu.org> <87bkx73jfz.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26767"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 11 14:46:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndtRP-0006nJ-K2 for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 14:46:47 +0200 Original-Received: from localhost ([::1]:49226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndtRO-0007DW-8x for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 08:46:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtPD-0005k8-Q6 for emacs-devel@gnu.org; Mon, 11 Apr 2022 08:44:32 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53726) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndtPC-000887-6i for emacs-devel@gnu.org; Mon, 11 Apr 2022 08:44:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GKEDMhyBn19FCeUxnougwVyMt041Z+cQk9UB5rscb48=; b=FGmCtNUm7AwABzOZRRQVJQFxXD pr69q2XqzqMIJtaRk8xIQzyikjVjp4vbpl9zbdr0dpewZPQIkE2rzccAr4OyXybawsvRYuiu++vkt KmYonhYBZjvapGnkglQUd0zJjjd0mV1eQbWSrrcDdum3yAM0oIXDsrAnMzJ2Flkaj4R8=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndtP7-0003Fo-8B; Mon, 11 Apr 2022 14:44:27 +0200 In-Reply-To: <87bkx73jfz.fsf@yahoo.com> (Po Lu's message of "Mon, 11 Apr 2022 20:15:12 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288181 Archived-At: Po Lu writes: > Shouldn't this be formatted like: > > void (*destructor) (void *); > > instead? Yup. >> + cache->spec = spec; > > I think this should be marked, since I don't see what protects the spec > from garbage collection otherwise. I suspect so, but as the comment on the previous line says, I wasn't quite sure. We're only using it to test for EQ-ness... but I guess that will break if we're using the complex Lisp object type. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no