From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master f515d658e5 1/2: Don't quote numbers in byte-run--set-* Date: Fri, 17 Jun 2022 20:08:35 +0200 Message-ID: <878rpv40yk.fsf@gnus.org> References: <165548588979.10920.4402229762078749924@vcs2.savannah.gnu.org> <20220617171130.8EDECC01685@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 17 20:09:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2GPl-0008Be-Li for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 20:09:49 +0200 Original-Received: from localhost ([::1]:57460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o2GPk-0002Hx-HE for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Jun 2022 14:09:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2GOk-0001Sj-4e for emacs-devel@gnu.org; Fri, 17 Jun 2022 14:08:46 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:48470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o2GOg-0000Yb-Ty for emacs-devel@gnu.org; Fri, 17 Jun 2022 14:08:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1A/EupQrBRxsco9L48E3g6+rVRIiQcvkNVpX6bBcJHc=; b=q78uY7BfFFKV95a6fiJ9OgrWbR 9kePie8x9Qykbdq1M/OUwg3UXp51C1kAsaM7upedRFFO07oFhVTGET4SbByYRPePS8x+Ku394eyfn mps+I5LysJBS+b8b+e2jyU8TDcC8WIqep8vqejXLfFOs/Ocij6Fo5lKtSqMCU8m8f78k=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o2GOa-0005nl-0R; Fri, 17 Jun 2022 20:08:38 +0200 X-Now-Playing: Boris's _bootleg -feedbacker- remaster_: "boris at last -feedbacker-" In-Reply-To: (Stefan Monnier's message of "Fri, 17 Jun 2022 14:01:44 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291311 Archived-At: Stefan Monnier writes: > - ''doc-string-elt (if (numberp pos) > - pos > - (list 'quote pos))))) > + ''doc-string-elt pos))) [...] > - (declare (doc-string cl--defmethod-doc-pos) (indent defun) > + (declare (doc-string #'cl--defmethod-doc-pos) (indent defun) Even though there's only one of these in-tree (at least I only got one error when I originally had the code they way you have here), I was thinking it might break out-of-tree code... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no