From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] new package: tramp-docker Date: Sat, 24 Sep 2022 18:56:33 +0200 Message-ID: <878rm8soce.fsf@gmx.de> References: <5674f36a-c276-fd77-b4d2-1525c75a1602@spork.org> <87y1uarnhu.fsf@gmx.de> <63d5f29a-05ed-f8c5-796c-a6eb9e28d575@spork.org> <87tu4yrmwi.fsf@gmx.de> <87mtaqrmio.fsf@gmx.de> <87h70xrrgi.fsf@gmx.de> <44bd6537-316c-acc7-a4d6-6123bc32e2c0@spork.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3806"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Brian Cully Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 24 18:57:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc8Ss-0000qQ-Qt for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 18:57:18 +0200 Original-Received: from localhost ([::1]:34344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc8Sr-00005b-U7 for ged-emacs-devel@m.gmane-mx.org; Sat, 24 Sep 2022 12:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc8SG-0007oX-9b for emacs-devel@gnu.org; Sat, 24 Sep 2022 12:56:40 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:54423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc8SE-0006um-GG for emacs-devel@gnu.org; Sat, 24 Sep 2022 12:56:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664038595; bh=guypEk85XFkM0564JFprvyyyUtHnwa/dJ3KseNdxiIY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=gU7iNBKq/zNeu4NYJr61ax3jk9NP1c0V2EJiBzmKQqTsL4IwLwcpowCnYgKFkzAvc DyXpPxEPIUCckyK+JgFeS4Yls6/UkAIEkyxR9fuwcYXMC4H69T55ZXHLvveijfGRPr BU3TYdw/qVPEjQMnRKeuKWHpDgN5LnxxeLiBbsfg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.156.101]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MvbG2-1pRTt70tC2-00sh9g; Sat, 24 Sep 2022 18:56:35 +0200 In-Reply-To: <44bd6537-316c-acc7-a4d6-6123bc32e2c0@spork.org> (Brian Cully's message of "Sat, 24 Sep 2022 09:23:22 -0400") X-Provags-ID: V03:K1:0KUeY4DlrJl96NhGFMe9FxEvdgNvS40xXxJ9BSrW7f68hftjMga +xiGNlMPsGvVzwM+qUspDvdIhqwvdaY669AaBSu1rRGbpEekN5b5GGBsy0kWdutbUPZ59Z1 EfjWoGj8JHr7x+VZyynMeo3vqR7G2YRVUYj1IXyCwvKniDwaG4f1j+Z1pnpuNuQrjbPzGLL 7Ii1JdswC+ModBasKoVQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Gv+oSIpAT3E=:fusyYqPjjPgdLF9pTlWzfk sUFN3245qwwPgEUs617UTvRQKTE5F4GhmgtGCkB+X/Ofq/EUZ1q9jQeCDp1CORKhom6AaK6dM MFtFICa+CufjldDFonZicenF8a8iRXiGsdLbpnLKrEy3BYvpR54qd7Y8XgCMCXj1Toa7rhpXL XOrMhynQ7d46lg0Y8dtTAQ2S4mF1aUZaQASBsLCX7Fkbk4SSfJQWqCzwnctf1W4rE6a59zvwR 7GG4ERY6OOBnD2TjxJT9bUUWgEFs4vVsFEa2djB86otPRseRCwPus/gXYLgWK26m8vEZyYymS Rc6MYZ1KckFB5yaPs1JyyOwCWt9tlKGfNCrevSinvs3pGCTj34n/yZEuLXNEYA1yj/W7hxPFz EpeeUn2YfQ6Ee+n45kcTzdSWotNXVSa8/h1Yr68OoJ12SCKhF1RkDV520Gy/qRYFz3T9YETrW GQh28Gmf1HZZog8eUtsdgalBO0bRRcsJrL4oKcNV8pyFGn06WXQgh/VCH4UMqPU0MnDybJqI4 mFLxKoWZeYcXTA3KgSxhi+ErxpcsO1PT9euTX8Mt3h7im8vt3ePJQBrs869GOAyxa7TaJ4bXv 8YaFqSSjsW/xmSzno76eyzd7WKe+KAAVpp+bAFkclQWmUJI9BkIGFdV6EEzFD+hitODwViyCl M/LOWobPAdvNLrUjAqqoXpZgCBAnjjNCd39xg9AanrfdALhV2ediuN+aXuIZ0GnOEadHHPB1l QsSqpFY4Cexo4cT56iTG49DMrFq2ncqFUzwPbX+XCuHNQiD5VKU4M/nCAJ0+NMnr/Up1NwxS Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296171 Archived-At: Brian Cully writes: Hi Brian, [pls keep the Cc, for the archives] > On 9/24/22 06:34, Michael Albinus wrote: >> It works almost in the Tramp environment. So I propose I add it (in you= r >> name) to the Tramp and Emacs git repositories, master branch. After tha= t >> I'll apply some changes for better integration, like removing >> tramp-docker-setup and friends, which aren't needed anymore. > > This sounds fine to me. OK, done. tramp-docker.el exists now in both the Tramp and Emacs repositories. Please check my changes, whether everything looks proper to you. >> You have a comment ";; todo: check tramp-async-args and >> tramp-direct-async" which I didn't follow yet, but this can be >> investigated also afterwards. > > That comment is there because I stumbled across the variable while > looking at some re-entrant Tramp errors, and it seemed like it may > solve them, but I couldn't find enough explanation to see if it would > apply to the docker case (though it seems like it should?). Feel free > to remove it if it suits you to do so. The idea of these settings is to improve asynchronous processes speed. It might also reduce the "forbidden reentrant call" errors in process sentinels and filters, but they cannot be avoided in general, because they happen also for timers. I will check tomorrow or so whether we could apply these settings. Another question: You have =2D-8<---------------cut here---------------start------------->8--- (tramp-login-args (("exec") ("-it") ("-u" "%u") ("%h") ("/bin/sh"))) (tramp-remote-shell "/bin/sh") =2D-8<---------------cut here---------------end--------------->8--- Are you sure, that /bin/sh will always exist in containers? And shouldn't we rather use tramp-default-remote-shell instead of hard-coding "/bin/sh", for the benefit of customization? > -bjc Best regards, Michael.