From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Mon, 10 Oct 2022 12:52:29 +0200 Message-ID: <878rlo54sy.fsf@gmail.com> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34731"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 12:55:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohqRe-0008oM-1r for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 12:55:38 +0200 Original-Received: from localhost ([::1]:60746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohqRd-0002yv-01 for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 06:55:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohqOh-0007Tn-6v for emacs-devel@gnu.org; Mon, 10 Oct 2022 06:52:37 -0400 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:56116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohqOf-0000iT-FF for emacs-devel@gnu.org; Mon, 10 Oct 2022 06:52:34 -0400 Original-Received: by mail-wm1-x32b.google.com with SMTP id t4so6596159wmj.5 for ; Mon, 10 Oct 2022 03:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=jw+IBYOSDOrqrF7PY7QDQd4s91ecwzcJDBuWNX1GzaA=; b=VE6f8A+/nKozucmNOrxTY3818R0qjSMIs9RbBqlkIpTqXNTyUDFpq71seEHQ0xpEI4 r4cYGQBOaKjIuai5o+e1g/lzRkkzA1JTWwrKX6zFoN8EhqDgBpsbAn798IRy8xta6zO5 zLhQLBi/RO8zG+bz0jByU6u8diGzpEg0L0Ri+Ix4gub8aNnf9PZJvH6JFvDLYQLgoxNg GvgVy5wkyTz5K1ei03VZe8w2ICtQcgvphiI2wr7VYt36htw7d4LjLKMBmUrpqicRpRUq esAaECoJlbbIQ7rEOkLMlPambXcfd7SV7RqWBvUGlwMgr4kre3Z7KvIuEBZD3uoo8cRr Etkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jw+IBYOSDOrqrF7PY7QDQd4s91ecwzcJDBuWNX1GzaA=; b=Hrb+0R8pIT2Ku2/sxGgqT2bHEOKzy2BkBlqwDvhsVTIboBy1CFg5x8bX+ec0FZDDef B5uPEP5aFTEbQeWldkDZr/N1D9linpkT4AAI4TBLeyaOdSLYU0wzPFBBGI8qQ4sQvYxk 9gPT3ThH5jrGg6lpC42jN4ArnMdKiYVO6XyUga7KW5PeHg7EPKTsC2Q52mbRrTTW/LLY r9pCzoqSTjLWpRTOAmpyFE7C09csofkEOIALOq3fq3779I3GgyZWDmtHbg6mPYHDG2ha 9IRucpGR9AG7NUGp5kEOmDYyjaqpPGJG7/Ec9KZZDLXnjchlFKYLNthpC0/jBWKWYpM/ tvcA== X-Gm-Message-State: ACrzQf17D0A8VGtyIwogA7VBqDiKyF2c9+sfOEcPsDBkhV4W6Q5rWaA5 Dm5ed+dUEOcf4JzaTTQUwnI= X-Google-Smtp-Source: AMsMyM5+2E0SUqQbB1QWp9ukgfTBLwQhmMWoz5XEPNxzhFndkiZU3IzE83q2Ji5rf1r9zbaLj0e5wA== X-Received: by 2002:a05:600c:5114:b0:3b5:428:cf67 with SMTP id o20-20020a05600c511400b003b50428cf67mr19814889wms.80.1665399151128; Mon, 10 Oct 2022 03:52:31 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:8656:7b7d:bd4a:27e3]) by smtp.gmail.com with ESMTPSA id e15-20020a05600c4e4f00b003c586bff0e6sm4809625wmq.14.2022.10.10.03.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 03:52:30 -0700 (PDT) In-Reply-To: <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> (Philip Kaludercic's message of "Sat, 8 Oct 2022 05:52:12 -0400 (EDT)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297358 Archived-At: >>>>> On Sat, 8 Oct 2022 05:52:12 -0400 (EDT), Philip Kaludercic said: Philip> +;;;###autoload Philip> +(defun vc-prepare-patch (addressee subject revisions) Philip> + "Compose an Email sending patches for REVISIONS to ADDRESSEE. Philip> +If `vc-prepare-patches-separately' is non-nil, SUBJECT will be= used ^^^ Beware the dangers of last-minute changes in default values :) I fixed it. One surprising thing that isn=CA=BCt called out explicitly is that if you do `vc-prepare-patch' for multiple revisions, it prepares the first patch, waits for you to do something with it (like send it), and then moves on to the next. I guess I was expecting it to prepare *all* of them (that way I could just save them all, and look in my drafts folder afterwards, and send them all at once). Maybe 'git format-patch' has spoiled me. Robert --=20