From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] On the nasty "ghost key" problem on NS Date: Fri, 04 Nov 2022 17:29:02 +0800 Message-ID: <878rkrcbkx.fsf@yahoo.com> References: <87leord0ei.fsf@yahoo.com> <87h6zfchpu.fsf@yahoo.com> <394D8618-AF36-44C4-BA64-7AFDFBBDC429@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26902"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Kai Ma Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 04 10:30:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqt1f-0006ku-Lx for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Nov 2022 10:30:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqt0n-0003W3-0B; Fri, 04 Nov 2022 05:29:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqt0m-0003Vl-0q for emacs-devel@gnu.org; Fri, 04 Nov 2022 05:29:16 -0400 Original-Received: from sonic309-20.consmr.mail.ne1.yahoo.com ([66.163.184.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqt0k-0004QJ-Hn for emacs-devel@gnu.org; Fri, 04 Nov 2022 05:29:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667554152; bh=KwAfT+DXqBG8Qxw+/SInJdgy8z2emcyxc0qspEL2uSc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=jrJ+9gtBJHlWvvlD0a6aoxAJIgOvEyIFJnMxt3aaJiW1mduSMjPzONVAGvVncN2v2lg9IZoGu7AbKBw6WP7PrLUh+uZ/v6zAzHB0Ce2CMFm4HJCLJzgvlPqODwHeESzWrKktnfpu6AIZ2mL6ejVagqXZOxHjQSbMiuMFMPEr7g5eyogypMgycuPTdT1fWzFgXAit3TrVWrYfMfQwTMXGn0j3nzC08q+UjwWOpn4QziC27EMlXZ4jnZ/RCx7xdXsFvEHkRSbyPkM4u17v3elYO/upJVsxlyXV0RBT+rsCx1MBqDDvZQ24yGvrUY3Vg1VIcP4eCy/ML45yWawxxM6QRw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667554152; bh=6W68FpOpojfOQf/HQ9xuAQKQKQDZ7FDYjDWRNmDHutA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CrePdVE12N8mMeSyS+/whbr7f4Tk1s05Mlg3Nj1nKFZ+e9LIlHrjiGCjzgPE3qh+Mk1ytOTbRQEDgVUNJg3Fh5JQSHIRBYrcM8NLmn8g9arpRNI0akAHNNN5IsVpfoRCqU11DAy3uWg5u2XGNqga1YeU2PVdHZ1k1p+Y9QBTurnnM/z5ZZZjSmjOkc/trzUdRbjgOa9u7kxvF8my+EZ3EcWuWFwIFBj6lvUxfaZ07RyvXWPNuFRXFggzhEqdZHxestysMZ02Xzz4m4Pfcvy899lUdkkJE5xq1fyFmaUzhxO4Mafu6YyJvrykAPfY5ui+wEj0eLjMjuUexRaf+SPs5w== X-YMail-OSG: 8_8OA7oVM1nGUG4Dq7ciw55UAQDM0wDCFd7aH_V9JHE20Uu_QjXySfbhleIfw9f syAUPIbgIy10em5sARokxQwZsdNJjfu9um3fZhAtJ8e.nhiGrepqLECW1.yv3YKSPLUwIMentoR_ 0ChyFZ7hdS_VYY_95OAz.ZGDB.nk.TyiTgBYTEMbYdK7C1pmYX3BjHvajueknJXUvFph6kKgDd57 B8jQe8hNoNCrH3MK3HKEiztwUdBp6xLCMc8IHyX4yzFlaFZQKozgu5jwe.ca7X3ik.r4z69Pc3Qs PO171f_CB_v96349s0lj1cvqzy.ID2b8CIQ1AcsFSoqwhRo81XLITSmB05bGh2DoYPJuuwx.NiPh x400QGfkH7og7T2dq4qIrKI1x_yklxKCKHIMsMYZcBzYwHPa1gEZE8Qyg5hsKWlBTHQdQj2J1ccR 8aAQui3GwR7UwofjsO492OhSMK.zEUYMjK.1WBA.JlkVhOBUHexwrKcEmTVIzAr8yDcbue3A8nME eT9vjPb6jluOk.Ro0fZJNVT4MUp5tvglDHUEtQGqhRx44ACiH_9s9CfspfCl3wenJr1mqU_0hdyi P99D_dwQe5khT5AkXUdGRU6wu4gqlMPsgxSdm_eFvVf2ss9Wq1gZZ_W02U.nbaG_uUdaELPgrnAT 3MrdKJOSM4hjr5FFHe8sNsw_VS.bn4kex7_TEqBq20sBvcC1uFO0Kb5MUjranQCtVqqWvZin8ykh wGeumNyvau1YM5UEmYajqqSixtb93TLDBzVlz5ysTwGeiRxrskvNkTdS8oItJjg69caeqjPgewPG HiIfgTsSS8vkMqwPLkzN684Z54F4_n3vPZz5RUCAwA X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Fri, 4 Nov 2022 09:29:12 +0000 Original-Received: by hermes--production-sg3-6c8895b545-xbfp8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 46b87a6bd6e245ea63f00998eee8296a; Fri, 04 Nov 2022 09:29:08 +0000 (UTC) In-Reply-To: <394D8618-AF36-44C4-BA64-7AFDFBBDC429@gmail.com> (Kai Ma's message of "Fri, 4 Nov 2022 16:53:34 +0800") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.146; envelope-from=luangruo@yahoo.com; helo=sonic309-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299118 Archived-At: Kai Ma writes: > Yes and no. Emacs still responds to new key events, but a previous > call is stuck and does not return. Presumably in another thread. To be > more clear: changing that code to be > > static int enter_cnt, leave_cnt; > enter_cnt++; > [referenced piece of code] > leave_cnt++; > /* (Or just count the return/leave counts of (ns-in-echo-area).) */ > > leave_cnt can be less than enter_cnt. I=E2=80=99ve confirmed re-entrance = to > [firstRectForCharacterRange] leads to the problem. I'm going to guess what actually happened is that ns-in-echo-area signalled. What happens if you replace ns-in-echo-area with: safe_call (0, Qns_in_echo_area) ? > Pardon my ignorance, is there any reason to special-case the echo > area? Simply let win =3D XWINDOW (FRAME_SELECTED_WINDOW (emacsframe)) > and the problem is gone. I don't know. I'd rather leave as much code untouched as possible.