From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Making `eglot-server-programs' a custom variable? Date: Sat, 12 Nov 2022 13:46:40 +0000 Message-ID: <878rkgz3nj.fsf@posteo.net> References: <86fservpri.fsf@gnu.org> <87cz9v97lo.fsf@posteo.net> <86r0yb234t.fsf@gnu.org> <87o7te7lc7.fsf@posteo.net> <83sfioob7s.fsf@gnu.org> <87wn80zjiw.fsf@posteo.net> <83leogo9yw.fsf@gnu.org> <87r0y8zhl9.fsf@posteo.net> <83k040o8an.fsf@gnu.org> <87mt8wzf20.fsf@posteo.net> <83edu8o5gw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, arash@gnu.org, emacs-devel@gnu.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 12 14:47:05 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otqqf-0005wS-Kx for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Nov 2022 14:47:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otqqL-0003VQ-NN; Sat, 12 Nov 2022 08:46:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otqqK-0003Ue-J6 for emacs-devel@gnu.org; Sat, 12 Nov 2022 08:46:44 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otqqI-0004iy-ON for emacs-devel@gnu.org; Sat, 12 Nov 2022 08:46:44 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 37AEB240106 for ; Sat, 12 Nov 2022 14:46:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668260801; bh=XrcGL2R5HJgTZQ7ScOhexpUvAIr/84W7HQ1dF+d7QhQ=; h=From:To:Cc:Subject:Date:From; b=hqRGK0xQbYM+IAKPKGsK3uTeOdBiO3mHIWzhZudiTq+tMew35cJHjTDSB+AsexwAs c3r1MJ0qaRY8l7hmU811GEnu99wXrupscDmwyvxT0mJGc+0K8/GXFaC/IIE4JVKDUy LJkX8TDkHZvh7ugi8IKwn86rYz+fA0SAFQoRRsK3UcJ3ICgoiQxslzJbgS9Mddt1Ip mA6sl8h9yIFv2181KLiu9tjUVWVN3RyQ8vNMZvVFIAK72p72NpuXMQ/covwuZ4bCEm A0PzV6YwN/QcKeuYzIh7KVHJ2FU+4szOc4Ga70Hp81PLazAjdoAK6C8YgGxY0AgCYA V/9mTCsB3d2mg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N8cLS2LQ3z6tnp; Sat, 12 Nov 2022 14:46:40 +0100 (CET) In-Reply-To: <83edu8o5gw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Nov 2022 12:02:55 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299651 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: jporterbugs@gmail.com, arash@gnu.org, emacs-devel@gnu.org, >> joaotavora@gmail.com >> Date: Sat, 12 Nov 2022 09:40:23 +0000 >> >> >> > The way to do this is to have a basic value as a defvar, and store the >> >> > corrections to that in a defcustom. >> >> >> >> But in that case you need to load the library to get the default value, >> > >> > I don't see why. And even if it's so, why is it a problem to load the >> > library? >> >> (I'm not just talking about Eglot right now) If the default value is >> defined in an non-autoloaded variable, you have to load the library to >> access the value -- otherwise it simply wasn't loaded. >> >> The "issue" here is just that loading everything you want to modify >> during initialisation can get slow. > > Whether or not it is necessary to load the library depends on how the > :set function of the defcustom is implemented. I can see several ways > of implementing it that won't require loading the library right away, > and I'm sure you can see those ways as well. Actually no, I am not sure I do. >> >> in which case you might as well store the default value in the >> >> defcustom. >> > >> > But you already explained why storing in a defcustom doesn't solve the >> > problem? So why are you suggesting to do that anyway? >> >> ^^ I am not sure I explained that? > > You said: > >> > M-x customize-variable RET image-load-path RET >> >> My issue here is that while you can modify the list, when saved you will >> store the entire modified list, and no the modifications you made on the >> base variable. > > To me, this says that storing the value in a defcustom hits that > "issue" to which you were alluding, and for which I proposed a > solution of having the defcustom be an add-on to the baseline value. I see. The issue is that if I just set the user option directly, say even before loading the library I overwrite the default value. But if I load the library, I will have access to the default value before modifying it and setting the user option. >> If you have to load the library to >> get the default, writing >> >> (setopt foo (cons 'bar foo)) >> >> or >> >> (setopt foo (cons 'bar foo-default)) >> >> doesn't make much of a difference to me. > > Sorry, I don't see the relevance of setopt to what I was trying to > suggest. There are two fundamental ways to work with user options, right? Using the Customise interface and programmatically, e.g. using `setopt'. The discussion began with finding a programmatic way of modifying the default value of a user option that contains some repetitive type (repeat, alist, plist), which we were calling `add-to- >> >> Also, I don't think this helps people who use the Customize >> >> interface? >> > >> > Why doesn't it help? >> >> Maybe I have missed something, if a user option has a `repeat' or >> `alist' type, you can't just say "append this and that value to the end >> of some other value". All you get to modify is the entire list, and all >> you get to store is the entire list. > > That's a job for the :set function of the defcustom. I am not sure I know what you are thinking of, but wouldn't this mean all user options that have already been marked as having a `repeat' or `alist' type, that these would now require an additional :set function?