From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Date: Sat, 19 Nov 2022 19:59:59 +0100 Message-ID: <878rk6u5w0.fsf@thornhill.no> References: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> <6DDC3B43-8B34-41A8-9BCA-77EEAD0EB124@gmail.com> <95C0B9E2-9C5B-4206-87D8-FA388DA3A1C8@thornhill.no> <83v8na7pww.fsf@gnu.org> <87bkp2u6j4.fsf@thornhill.no> <83tu2u7p7i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, jostein@kjonigsen.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 20:01:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owT5V-0000mt-Le for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 20:01:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owT51-0005tR-GO; Sat, 19 Nov 2022 14:00:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owT4m-0005pY-0V for emacs-devel@gnu.org; Sat, 19 Nov 2022 14:00:33 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owT4U-0006Pm-3G; Sat, 19 Nov 2022 14:00:20 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668884407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2mylWU8rdhWmP8cP63+A0fbthiJpGG9lTkyGTevc2KA=; b=O9TwZR3J8CmhE8q0QWXa5yucylzNIVsLCJJNejMIXcHJXhDoLCxUihL5haNKY8HznWts7S wYnLu+w4XUcjP5egqkzUDprVgG/UWlayM44Gdsui6kfhvFtRGjjr45whPWxurAGBzsyVgj A/8zFZhsW4X1BOWOHuqHpGwHCByi9SNfvzwmqbeiAsHd7JmqLa1xie0ofh4Ndxpo1fs2U2 8wX/V9VhxsMtbsKol6oKWaD4Wdqc6j3tIrhKb/sfXEekMjhesb6s4jt8NHs/tl1WpJcsFW tmneR8OBX9DImJ1N0Hwb7olGFbNYnOhpCLrdbOhO/iqZC9oHZL64ZsmJDOKUvg== In-Reply-To: <83tu2u7p7i.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300197 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: casouri@gmail.com, jostein@kjonigsen.net, emacs-devel@gnu.org >> Date: Sat, 19 Nov 2022 19:46:07 +0100 >> >> Eli Zaretskii writes: >> >> > Btw, should we add C# to c-ts-mode.el? Or did we already discuss that and >> > decided against? I don't remember, sorry. >> >> I don't think we decided against, and we didn't really discuss it. IIRC >> your "challenge" was for the cc modes already included in emacs, and C# >> is not that. But seeing how there's a functioning cc-based c#-mode, I >> could tweak that to include both. The Cc mode variant is very stable >> and have been for some time already. There's no need to maintain the >> one in ELPA, and as I'm the author of it I think we can merge both? So >> we can have in-tree support for c# whether or not you have tree-sitter >> enabled? I can whip up a patch for that if you want, or we could just >> add the tree-sitter variant. In any case, I think c#-mode should >> probably not be inside of c-ts-mode, considering that it's not a >> superset of C, like C++, but its own entity. >> >> What do you think? > > It's fine with me to have C# support both with and without tree-sitter, if it's > indeed easy. Gotcha. The few commits that has happened after I rewrote the cc mode variant should be compliant assignment-wise, but I'll double-check. Most are very, very small. @jostein, could we just iterate on it the next couple of days? I can do the coding, but I'm not bathing in C# these days, so it would be nice with some real life usage too :-) Theo