From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals-release/org e2366ac283: * lisp/org-persist.el: Do not litter /tmp when native compiling Date: Sun, 25 Dec 2022 09:22:19 +0000 Message-ID: <878rivu9bo.fsf@localhost> References: <167164907706.9937.9724677162932540750@vcs2.savannah.gnu.org> <20221221185757.74391C00613@vcs2.savannah.gnu.org> <877cyka7q3.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17809"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 25 10:23:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9NDs-0004PP-2Y for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Dec 2022 10:23:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9NDD-0004Ue-GE; Sun, 25 Dec 2022 04:22:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9NDB-0004U4-AI for emacs-devel@gnu.org; Sun, 25 Dec 2022 04:22:29 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9ND8-0001rJ-Bx for emacs-devel@gnu.org; Sun, 25 Dec 2022 04:22:28 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EF1612402D8 for ; Sun, 25 Dec 2022 10:22:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671960144; bh=EaRH2sgmskXbvGWFelveN/otDe/clnsLdMSEnxtn0bc=; h=From:To:Cc:Subject:Date:From; b=DA1cbcyzPBp3JMgFcpqPl4H4lm1FXvp1h8cACpQ2wJMiMFEIYycSuBJ6co26xzDF1 TtaeOqbx/CMelwGwyh2P7m8vR8AukW0WxZNNghkDfwGN+oypqnC8SGiblkAWjnCZsm a5Qd+aP6pU6mujrgFlHQ5fOfcEwsz+6n4rwwcZTJHWNjkAQYcP1pVUnKQd1QPy4P/B RexlOoH1XrREVORSfSg8nZvXxbt+1AwdyLaftYe7yaOmyAQ8KGmaLHOQJOWRgm/AUN P0I2SxPOVoTdpR0pvmgVvCat7luftZ8MGpO0BPn35x9qwHoGCXDVzMsldEUaE/98QL EUdzIp4ksQl7A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NfwRg2Czfz6tnw; Sun, 25 Dec 2022 10:22:22 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301906 Archived-At: Stefan Monnier writes: >> It would be wonderful, but >> >> There is a race condition between calling make-temp-name and >> later creating the file, which opens all kinds of security holes. >> For that reason, you should normally use make-temp-file instead. >> >> which scared me. > > By keeping `org-persist-directory` but deleting the dir, you basically > turn the narrow window of the race condition into an arbitrarily > long window, so your code is worse than using `make-temp-name` :-( Fair point. I now fixed this by creating the directory at the beginning and only removing it before exiting Emacs. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=987fe173acf6c6fdb4bec5c5c07796d98c6e1983 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at