From: Po Lu <luangruo@yahoo.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: file-equal-p
Date: Thu, 16 Feb 2023 17:58:29 +0800 [thread overview]
Message-ID: <878rgyq6d6.fsf@yahoo.com> (raw)
In-Reply-To: <mvmv8k2rmxw.fsf@suse.de> (Andreas Schwab's message of "Thu, 16 Feb 2023 10:15:07 +0100")
Andreas Schwab <schwab@suse.de> writes:
> On Feb 16 2023, Po Lu wrote:
>
>> diff --git a/lisp/files.el b/lisp/files.el
>> index b0ec6bb09d0..dcd17df166a 100644
>> --- a/lisp/files.el
>> +++ b/lisp/files.el
>> @@ -6360,7 +6360,17 @@ file-equal-p
>> (let (f1-attr f2-attr)
>> (and (setq f1-attr (file-attributes (file-truename file1)))
>> (setq f2-attr (file-attributes (file-truename file2)))
>> - (equal f1-attr f2-attr))))))
>> + (progn
>> + ;; Haiku systems change the file's last access timestamp
>> + ;; every time `stat' is called. Make sure to not compare
>> + ;; the timestamps in that case.
>> + (when (and (eq system-type 'haiku)
>> + (consp (nthcdr 4 f1-attr))
>> + (consp (nthcdr 4 f2-attr)))
>> + (ignore-errors
>> + (setcar (nthcdr 4 f1-attr) nil)
>> + (setcar (nthcdr 4 f2-attr) nil)))
>> + (equal f1-attr f2-attr)))))))
>
> Why does that compare more than the inode and device number? The other
> attributes can change any time, if another process accesses the file or
> modifies the inode between the two calls of file-attribute.
That's what I thought too, but it's not a good thing to doubt code that
has existed for a long time.
next prev parent reply other threads:[~2023-02-16 9:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a61es8fh.fsf.ref@yahoo.com>
2023-02-16 1:30 ` file-equal-p Po Lu
2023-02-16 8:18 ` file-equal-p Eli Zaretskii
2023-02-16 8:43 ` file-equal-p Po Lu
2023-02-16 8:57 ` file-equal-p Eli Zaretskii
2023-02-16 9:59 ` file-equal-p Po Lu
2023-02-16 11:52 ` file-equal-p Eli Zaretskii
2023-02-16 12:34 ` file-equal-p Po Lu
2023-02-16 12:42 ` file-equal-p Eli Zaretskii
2023-02-17 2:40 ` file-equal-p Po Lu
2023-02-17 6:26 ` file-equal-p Eli Zaretskii
2023-02-17 7:07 ` file-equal-p Po Lu
2023-02-17 8:32 ` file-equal-p Eli Zaretskii
2023-02-17 11:05 ` file-equal-p Po Lu
2023-02-16 9:15 ` file-equal-p Andreas Schwab
2023-02-16 9:58 ` Po Lu [this message]
2023-02-16 10:35 ` file-equal-p Michael Albinus
2023-02-16 12:35 ` file-equal-p Po Lu
2023-02-16 12:43 ` file-equal-p Eli Zaretskii
2023-02-17 4:50 ` file-equal-p Richard Stallman
2023-02-17 10:02 ` file-equal-p Andreas Schwab
2023-02-17 12:25 ` file-equal-p Eli Zaretskii
2023-02-17 12:45 ` file-equal-p tomas
2023-02-17 13:17 ` file-equal-p Andreas Schwab
2023-02-18 12:25 ` file-equal-p Eli Zaretskii
2023-02-18 14:04 ` file-equal-p Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rgyq6d6.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).