From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nikola Pajkovsky Newsgroups: gmane.emacs.devel Subject: Re: Eglot "inlay hints" landed Date: Thu, 23 Feb 2023 22:45:52 +0100 Message-ID: <878rgo6oof.fsf@gmail.com> References: <83edqqaf8c.fsf@gnu.org> <2B284D77-97DF-4B3E-89FB-13F0CA93D240@gmail.com> <87356xv65z.fsf_-_@gmail.com> <87zg94kvoq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Nikola Pajkovsky , emacs-devel@gnu.org, Dimitri Belopopsky , Chinmay Dalal , Po Lu , Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 24 07:40:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVRkn-00034K-TT for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Feb 2023 07:40:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVRkD-0004gd-A8; Fri, 24 Feb 2023 01:39:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVJPa-0002wn-CP for emacs-devel@gnu.org; Thu, 23 Feb 2023 16:46:01 -0500 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVJPY-0005hy-Ha; Thu, 23 Feb 2023 16:45:58 -0500 Original-Received: by mail-wr1-x429.google.com with SMTP id q16so1645890wrw.2; Thu, 23 Feb 2023 13:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+KDaSzFIDrVupE314K/i4f7OyOrpvYmu1N94/hK7MzM=; b=li3/gt7QqR+Mdy0UwGwzvEFc/Fjek17Zq/Dwtu2vBAonUnHGpmbH5plO5bKkrsukqJ aGQn1auatP85fmY/OrLqsJEj8PRX2Fwmrin9C47jwvHWIZ22qpSkhNuATJXUWsptMDQJ jOnj9tZfcGdLU86uXv85+zUScTfmQHm6NrQec6G+Ep5VbVkSfE6a4q8UFe9yzIsvbKDH qaIbq0zDp7eSWZn0ZliNRPpCxXmwwGwA3/FdyL6axc+qyr+CfwLmJ5e8WH7qY8BF8ZtQ Lz0QuiJeEOVI2XrrtgPczMmYHxLbD/SZzs8qDu+52SCCDxvtPnpv7rDHpGGOgPYHKz5J vilw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+KDaSzFIDrVupE314K/i4f7OyOrpvYmu1N94/hK7MzM=; b=DJjHCV8KbMuW1GtCA0BB3Uq12cflzVhApL06oVPJUXKyjBy/nSiI7kGwy2riDzxZo5 PM0OJOs9QrV9bxRgx7ysKyRPHDUzBOpWSqIk/kpq0ofmjCb/2XlxRV6c3CIM8JibAh5I FnXotbKbgkZna+iZEl2CAAAC6VcD0SBlHqQKqsDh4n7ec/iIsAr6tUay66z94ID7WpXc cTGPWN1fDcBPFbuB4gcNnAjP3oPr/e/PDscGW/trRvwC1+BBW2DkGI9jz9ZbRt/+N6qM wUQkzuq24IBSlPWE0Y3VWOB3dlzdfCnE0oDfEUiBvU1TSY/J6Ovj9SJvRowpaxH42REt 7TvA== X-Gm-Message-State: AO0yUKUipE4wN8+c/NDonXF/z0+thrqBCTd34TI9Isu009n+ruKUvYQN OXvI0yCmMpTghJvFDhO8P1M= X-Google-Smtp-Source: AK7set8hxkNkcV0+vdk1hN7XmdA1iDEL72uqwciKCkIsK8Xvu+YJVkeZvbsKVn5NFyv/5mcvIJetpA== X-Received: by 2002:adf:f245:0:b0:2c7:ca2:1a28 with SMTP id b5-20020adff245000000b002c70ca21a28mr5969541wrp.68.1677188753666; Thu, 23 Feb 2023 13:45:53 -0800 (PST) Original-Received: from localhost ([2a01:4f8:151:3141::2]) by smtp.gmail.com with ESMTPSA id r1-20020adfdc81000000b002c5503a8d21sm9036827wrj.70.2023.02.23.13.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 13:45:53 -0800 (PST) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Thu, 23 Feb 2023 21:35:40 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=n.pajkovsky@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 24 Feb 2023 01:39:45 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303738 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Thu, Feb 23, 2023 at 7:50 PM Nikola Pajkovsky = wrote: >> >> Jo=C3=A3o T=C3=A1vora writes: >> >> > I've just landed Eglot "inlay hints" on lisp/progmodes/eglot.el in the >> > emacs-29 branch. It's a feature that some users (including me) were >> > looking for for some time. >> >> Nice work Jo=C3=A3o! >> >> I tried rust inlay hints, and it does not work for me. I bet it's because >> eglot uses label only if it's string. The same problem was in lsp-mode. > > Actually, I think I have code for that. So please show a reproduction > recipe. I think someone reported here that hints are working > correctly with rust-analyzer, and I've tried it briefly myself with good > results. So it must be something else. Interesting. ``` -> % rust-analyzer --version rust-analyzer 0.3.1402-standalone ``` For instance, I don't see the inlay hints for the code like this: ``` struct Foo { b: u32, } fn main() { let s =3D Foo { b: 10 }; let f =3D std::fs::File::create("t"); } ```