From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Thu, 09 Mar 2023 18:22:09 +0800 Message-ID: <878rg6jkby.fsf@yahoo.com> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> <87r0tzoeam.fsf@yahoo.com> <87a60no7su.fsf@yahoo.com> <87edpzplom.fsf@gmail.com> <87a60npirc.fsf@gmail.com> <83mt4n49az.fsf@gnu.org> <87wn3rnos1.fsf@gmail.com> <560b874e-f67e-0b45-d489-8a45c4d8312d@gmail.com> <87sfeenuft.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12306"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , Eli Zaretskii , ulm@gentoo.org, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 09 11:22:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paDQC-000348-Dp for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Mar 2023 11:22:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paDPl-0002nH-0I; Thu, 09 Mar 2023 05:22:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paDPj-0002n2-Ag for emacs-devel@gnu.org; Thu, 09 Mar 2023 05:22:23 -0500 Original-Received: from sonic317-28.consmr.mail.bf2.yahoo.com ([74.6.129.83]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1paDPh-0003Io-SK for emacs-devel@gnu.org; Thu, 09 Mar 2023 05:22:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678357341; bh=Lu3CZr5kPmoSG9HtwE0tJcUJitQJA4pFGRAv1udAF98=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=NhI4iVWWAdPwd1CmIyI9zoxY0SJuJy5nWtK/JkyP55FB75dHFcyaz6XF/TPlfm4WUjqibS11+kqUoqtFIPn2Mx6u9fx7NvLXFqsZCTAw9q01qav2OBBeZuKsUMrchuX9UrDz4QQQ3+L35blUKDD53GfZzgfMsWS8kcI+qETQOVBJqEPquwtGUaDjCEgEJnNQsQgfWJEicbQhlFoTEasQognF6KvleKd7+IbxZWHE/k0wIfV9UmlFBCwUX70kH26//3CXNKwxlgy38ll6Ov4KN9Nwq6mH/WMrp8h+bD2wNZQMcT2E7aPA/oK64Cp5KmjwOBEBCUH2eDeVPhRYdJgJNQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1678357341; bh=CHlKfLZ+wOVi2KXj8dEdyBve53uFiDvORPrYNSQf9Xo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=JoUrUVLN4MhgFGRx/1P8W0fNALVBPM5sm4hP8iulkUGvpnnGXSejYW8vX2YHShFmm1ma8RqUUXBe+4AkH2SMbdetO0x6+1Mad8p8tYnYFWMdaCjWysmfywnihfHEEwmISfb7YAETyYgiY937C/AQH0v7bGXuUYXduutYd/6SdbO1RNnRIXNdttJ+UH48v0eKWb3+mYyju038GOd4iJa0PVCcMrBxJUMBLl/egm8AqpcKVkMOV+Rg4275xOgP9LBAxFRtZGBK4japsU9RwTTIgdVBTAPeth/qldb28yuIzIqCp1xoBMH90u4yHyLzE/ixUevm+SOxswBfJl68xQDoKg== X-YMail-OSG: hmEFlogVM1kKoRCzRePM3oB4EGaG62nYy9qaiDR386q.ljSEtr.yBNBdlCOk.Ux I74LGb9HtXShegqnLU5ON_NdVTFoq2ZNdRHPYkaWhCZx0HmULdvU3uzbZlK2MYEwmw.kWfSXCg5K 2r_d7vJ1gMvz9x86dWAoW1GxBCovsp1mvogslnmJJt4HI4bDhhEb.MKwkCpAilwwqQDhDuJ6WeZt 3k7nmYgNUi4K65rXnEnnQZpqn3ubX3c2dMplTYj7QPMnd98y8PHo6EsBFyILQBUdPOVmuENWUMLA F.Jwks4yg5tUXqcm6kcLNmXgnMjwaudGPJkpD0dShRgeU_kSV3TsAc2HLfc0z.tz6RVEachCGTYr npJTvdfXrYd5VSQ7dZsxHWBaTPI3_jxytQEBJQFHgCI3buIENRdFS8TjR4wjX.bPidttzMu5Ckr7 3wBbbMnaPkBaYZxLAn.4uIru3S2Bxo77v.5Wj572NQJ2IY19pXV3wAFmRLeEQ01bdK.sn3JN6cfE c5DDSTfoOtkWEaOUD0FvGr0sd2iHvW9xRb2ctKo_HdAkVOhbYhrSxdGSRB6HR5GgP3gyjrx_mBro C32lWvUn8O.B1q3du2GyimabS7MUsteM_6U6kKwzVbcjC_t7.2nOsnEynNG3o0PC25S8M.1cmlpt 1sDufpOuZqtMHaw5vmg.nRzS0EJwh3Lf1SgZ7tDSeV7ygw4bH3Fz6K0DznsH3_AF8JEtZCAHK3FY VYj9TMNWBYmG0jXl9hVe5_j8pS_bIxMM.J7x2fByYy3z1z6SfYQnBvCptXuK2Z42_P2DCSk75Xr1 dxZ25_UWMbEpzm7qHh6wbcCnyQ9gxdu3IEudsjNqpd X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.bf2.yahoo.com with HTTP; Thu, 9 Mar 2023 10:22:21 +0000 Original-Received: by hermes--production-sg3-67c57bccff-b6t8r (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3930d82502f12a17e80ff4cf346e87bd; Thu, 09 Mar 2023 10:22:14 +0000 (UTC) In-Reply-To: <87sfeenuft.fsf@gmail.com> (Robert Pluim's message of "Thu, 09 Mar 2023 10:30:14 +0100") X-Mailer: WebService/1.1.21284 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=74.6.129.83; envelope-from=luangruo@yahoo.com; helo=sonic317-28.consmr.mail.bf2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304181 Archived-At: Robert Pluim writes: >>>>>> On Wed, 8 Mar 2023 10:54:08 -0800, Jim Porter said: > > Jim> 'set-arg' is probably simple enough that we could expect users to > Jim> write it themselves. '--apply' is a bit tricky (for emacsclient = at > Jim> least), since we'd need to properly escape strings. I guess the > Jim> complexity of doing this would depend on how we did the escaping > Jim> though. > > I=CA=BCm not sure what escaping is needed. We take each command line > argument and pass it to emacs wrapped in "" so it=CA=BCs treated as a > string. > > Jim> For reference for this thread, the conclusion we came to in bug#= 57752 > Jim> was an interface like this: > > Jim> emacs --apply func1 arg1 arg2 -- --apply func2 arg3 arg4 > > Jim> (Ditto for emacsclient.) > > That=CA=BCs not that easy to do with our current usage of getopt. For > emacsclient, OTOH, the following is pretty easy to support without any > changes to server.el > > emacsclient --apply func arg1 arg2 > > since --apply can (ab)use --eval internally. > > Robert I'm not quite familiar with emacsclient, but can't we have emacsclient run Lisp from stdin? That sounds much more flexible.