From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Wed, 26 Apr 2023 10:17:08 +0200 Message-ID: <878reft5vf.fsf@gmail.com> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> <838regwcnt.fsf@gnu.org> <87fs8o9spe.fsf@gmail.com> <835y9kw5ix.fsf@gnu.org> <86h6t3rjl8.fsf@mail.linkov.net> <83leifvqsz.fsf@gnu.org> <86wn1zoofr.fsf@mail.linkov.net> <83h6t3vo47.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juri Linkov , michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 26 10:18:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1praMD-0002AM-07 for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Apr 2023 10:18:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1praLB-0005L0-Pj; Wed, 26 Apr 2023 04:17:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1praLA-0005Km-9z for emacs-devel@gnu.org; Wed, 26 Apr 2023 04:17:28 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1praKu-0001oN-Ms; Wed, 26 Apr 2023 04:17:28 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f19c473b9eso109073885e9.0; Wed, 26 Apr 2023 01:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682497030; x=1685089030; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=5Rhd/RvIHmxCduYqi8NH87sh3RWtC0zANkX2AmcgkUs=; b=U555ypd6tJ8SWIweuI+WrcIcBIdVpGTuqVik20pZZePbbHS6sD2ftQW7zz4Nysw5ND 9+fUp7aVuWdHMDM/VF0qu68nzLjz55HiZML3Qd7C2pGUHc/3xCH9uTpvIQbiw+HdBGy2 yxAJlQG68ft2Q0icqXlROwASZjemBOskHcjyM64tQfABP4ZQn6dxd5kBEZoV5U1sJAD0 XHt+6TvjxPuaTCzuIIMOfG7DXvmvPpbSe7C+FrA4F9M198FOiSTITJ5ivbh1O5VOOQa+ bH4crKEE3UhngNqZzYc8cGxDo2Iv4ASSx8EoPA45iWKoXvqMLrJl3InfhXPxzz33B7gS clXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682497030; x=1685089030; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5Rhd/RvIHmxCduYqi8NH87sh3RWtC0zANkX2AmcgkUs=; b=c717190jsLuNFHZN79sWa3EFcN/CXNI8SXpcwuOjJgZ/4Eh8lYaU7q+Hu8hAfg1W2o yPUuJCBy2yjAxzZZGXdFtTjsCRF7Mncm8HOpWKEwoK5k3jClclahE2I4FG/zmwh8ntwd lKxMTjHRXg+h8D2+dMBAgoNOM31oLAVZ5ndf7FXVUgG+nuXAv48mkyFBqetH+mE7F2rc YUjG0kJbQvOfjE+WZUC/z27aLXh15HeiWCpEwsif3leNkHUi/8S4jOCRhWlxXrkguNs2 AN0VPIzDq6xkBNnO8AQ1pSixnKT0YDHbRnVvsN7abln8ZDQlaCM6U+8YIN3LyngYRV9e SXMw== X-Gm-Message-State: AC+VfDxfGXBc2f1zktynspBDZD1yqkWH4T+sU5JzU7kLJZhIMk81BzDn obc7WxBiJ5i6tp6CP3OREtKkFUKYtGQ= X-Google-Smtp-Source: ACHHUZ6H5jrQ06kxyElUN0yxKk0V5iOjjdhcG3tQyph8oriW0B7E4QWVIquobRZ72H4PPB296fQgWw== X-Received: by 2002:a1c:7301:0:b0:3f1:6f57:6fd1 with SMTP id d1-20020a1c7301000000b003f16f576fd1mr1197350wmb.9.1682497029753; Wed, 26 Apr 2023 01:17:09 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id x9-20020a5d60c9000000b002fbdb797483sm14946137wrt.49.2023.04.26.01.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 01:17:08 -0700 (PDT) In-Reply-To: <83h6t3vo47.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Apr 2023 21:00:08 +0300") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305676 Archived-At: >>>>> On Tue, 25 Apr 2023 21:00:08 +0300, Eli Zaretskii said: >> >> So I see no reason to remove 'custom-function'. >> >> What could be done instead is to add a new choice >> >> 'custom-predicate'. >> > >> > The suggestion is not to remove custom-function. The suggestion i= s to >> > require that the function returns a boolean, to mean whether to hi= de >> > or not to hide a heading, instead of requesting that the function >> > itself hides/unhides the headings. >> > >> > What is the purpose of requesting a custom function to actually >> > hide/unhide the headings, i.e. to know enough about the structure = and >> > internal details of Outline mode to do its job? >>=20 >> How the user would be able to use 'outline-show-branches' >> in the custom function, and not to use 'outline-hide-entry'? Eli> Sorry, I don't understand the question and its relevance. Maybe Eli> Robert does. In the current implementation, the user is free to write a function that uses any of the outline-show/hide functions to get the effect they desire. If we replace that with just a predicate function, then they=CA=BCre effectively restricted to `outline-hide-entry' and `outline-show-subtree'. I guess we could add `predicate', to be checked before `custom-function', if set. If we do that, we definitely need to document which outline functions are available. 100% backwards compatible as well =F0=9F=98=84 Robert --=20