From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: hierarchy-print doesn't allow sending indent-string arg to hierarchy-map Date: Thu, 13 Jul 2023 05:38:11 +0200 Message-ID: <878rbkmqfw.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13315"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Damien Cassou To: emacs-devel@gnu.org Cancel-Lock: sha1:ebgH2udYl2sR6mAsmZXjCH3CNu4= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 13 05:39:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJnAp-0003Bm-9S for ged-emacs-devel@m.gmane-mx.org; Thu, 13 Jul 2023 05:39:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJn9y-0002c9-AX; Wed, 12 Jul 2023 23:38:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJn9w-0002bx-B3 for emacs-devel@gnu.org; Wed, 12 Jul 2023 23:38:28 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJn9q-0006xX-Ia for emacs-devel@gnu.org; Wed, 12 Jul 2023 23:38:28 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qJn9o-0001zE-0S for emacs-devel@gnu.org; Thu, 13 Jul 2023 05:38:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307805 Archived-At: Hello, Maybe Damien (the author) doesn't read this, I added an CC field. mousebot writes: > hi emacs, > > `hierarchy-labelfn-indent' takes an optional second argument > `indent-string'. > > `hierarchy-print' calls `hierarchy-labelfn-indent', but doesn't allow > providing it with an `indent-string' arg. > > it also provides no second argument to the labelfn arg of > `hierarchy-labelfn-indent'. > > hierarchy-print looks like this: > > ``` > (defun hierarchy-print (hierarchy &optional to-string) > "Insert HIERARCHY in current buffer as plain text. > > Use TO-STRING to convert each element to a string. TO-STRING is > a function taking an item of HIERARCHY as input and returning a > string. If nil, TO-STRING defaults to a call to `format' with \"%s\"." > (let ((to-string (or to-string (lambda (item) (format "%s" item))))) > (hierarchy-map > (hierarchy-labelfn-indent (lambda (item _) > (insert (funcall to-string item) "\n"))) > hierarchy))) > ``` > > > i'm working on a client and i'm using a copy of `hierarchy-print' that > looks like this: > > ``` > (defun hierarchy-print (hierarchy &optional to-string indent-string) > "Insert HIERARCHY in current buffer as plain text. > > Use TO-STRING to convert each element to a string. TO-STRING is > a function taking an item of HIERARCHY as input and returning a > string. If nil, TO-STRING defaults to a call to `format' with \"%s\"." > (let ((to-string (or to-string (lambda (item) (format "%s" item))))) > (hierarchy-map > (hierarchy-labelfn-indent (lambda (item indent) ; add indent > (insert (funcall to-string item indent) "\n")) ; add indent > indent-string) ; add indent-string > hierarchy))) > ``` > > i provide optional arg `indent-string' and hand it to > `hierarchy-map'. i also provide a second 'indent' arg to the lambda > that is the first arg for `hierarchy-labelfn-indent', indent is then > given as the last arg of `funcall'. this allows me to print indented > tree structures, which i was unable to achieve otherwise. > > is there a reason this isn't the way `hierarchy-print' is coded? is > there perhaps another way to achieve the same result? i have little > experience with `hierarchy.el'. > > regards, > m