From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Fri, 24 Nov 2023 22:43:27 +0100 Message-ID: <878r6mx1xc.fsf@betli.tmit.bme.hu> References: <953056ea-9cfb-34ad-6515-9036633dfdbb@yandex.ru> <2d964697-2b4e-64c7-2f16-aae87e57def4@yandex.ru> <87il697r5g.fsf@catern.com> <87r0kw8nxu.fsf@catern.com> <3fe5a8cd-b355-d7eb-10ad-8846aef3387b@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33463"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: Spencer Baugh , emacs-devel@gnu.org, Eshel Yaron , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , John Yates , Ergus , Filipp Gunbin To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 24 22:44:18 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6dyE-0008Wu-If for ged-emacs-devel@m.gmane-mx.org; Fri, 24 Nov 2023 22:44:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6dxX-0007p6-5i; Fri, 24 Nov 2023 16:43:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6dxV-0007nq-Ay for emacs-devel@gnu.org; Fri, 24 Nov 2023 16:43:33 -0500 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6dxT-0005x9-P0 for emacs-devel@gnu.org; Fri, 24 Nov 2023 16:43:33 -0500 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-507ad511315so3239266e87.0 for ; Fri, 24 Nov 2023 13:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700862209; x=1701467009; darn=gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Kj36TYu1BF+r0O2RCAoJ1IUgBGyCS8htm8lDffsnfzI=; b=mcSn+OKwdPhj+5pI428tMdKJF6Vj/JOgCJ3k+roHjcj9l+dx4o8fjwWvtR1nb8bo+w kCmW5Q1cCgOnHfY7+4no3OfwNWkvgCd2z7oVe96W+rt5nvON5d34bnjQAARNBz/kPq85 xFkRZ2T4V+57LsQqOOZQgFSnOIbAGp7ZtRH3xbjTjhRg3UJIQYgY3O3/qHhk5LWsVjpH 3uncomkh3BT4nJsKJk5Wqh8/zF3vvLN3VjP+q4NkTMRMRiZZI0IW3sWguIKtuscCKEj6 IXm8ab4lqkVOtkKU/V108IHhv7FGi2jlXSS0+nupbBc6nOM/Ii/M5k6T7yhIC4Hd5Ut1 Ak+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700862209; x=1701467009; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kj36TYu1BF+r0O2RCAoJ1IUgBGyCS8htm8lDffsnfzI=; b=X2mHn/bW/f0Y97R9h9BieP3CNrpZMrM6kuvulioAW84WV3CBXl7qGd+GoO/TY+sBzv rpEfyWj6/xvsRWEQ2qWFFepIy7/f1tyahtZXv76jNDZ0UUx79th6FnNY2baiR6xXT12i S0dGUXNJlB3osBRfZdAG+U7lX2AJzDVFa6seYQ2+p6rgJNS7/8l6LP0eDOwH9YKJJvjJ /yvLdq0Tgm7u+Ns3zmoQ76wxCWg3EwnDLLYoYvL0cEBgwzA519BlGyDjY9hR8ycGR39E 6R+4OUFJnW09lolguxlZVIhV6UeYVU+FaZkfG0dlQ8CUzFvEmaF27357VhpIsOUxIrDx STCA== X-Gm-Message-State: AOJu0YxCQ7buqrTUNlA9Y/ZCzebnL/yYmMNrb6mCjqmfiDVItuOiHPck C8BOvt1IhxNrVeOTCNkL9MM= X-Google-Smtp-Source: AGHT+IHXNZ+4bGQ+jIEEEC7ECwcb+Qe9TQG5JegHR7Ypd8bWMBCqRMHDlyCDFPLMt+J+pITxPJ0uPA== X-Received: by 2002:a05:6512:1308:b0:509:cbfa:1c31 with SMTP id x8-20020a056512130800b00509cbfa1c31mr3278411lfu.40.1700862208994; Fri, 24 Nov 2023 13:43:28 -0800 (PST) Original-Received: from betli.gmail.com (catv-89-134-210-182.catv.fixed.vodafone.hu. [89.134.210.182]) by smtp.gmail.com with ESMTPSA id x13-20020a170906710d00b009b2ca104988sm2557772ejj.98.2023.11.24.13.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 13:43:28 -0800 (PST) In-Reply-To: (Dmitry Gutov's message of "Fri, 24 Nov 2023 03:37:37 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= Received-SPF: pass client-ip=2a00:1450:4864:20::131; envelope-from=felician.nemeth@gmail.com; helo=mail-lf1-x131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313186 Archived-At: Dmitry Gutov writes: > Anyway, I've pushed an update to the same branch > (feature/xref-find-extra). > > What does everyone think? I haven't followed the discussion, but the extensibility of it is just great. I think it is a minor inconvenience that it is not possible to use directly the symbol-at-point as identifier while asking the user for the kind. That is a prefix argument causes xref-find-all-definitions to ask the user for both. eglot-find-declaration, eglot-find-implementation, eglot-find-typeDefinition still use the now non-existent xref-find-extra. Thank you.