From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Date: Tue, 30 Jan 2024 22:11:14 +0000 Message-ID: <878r46v5dp.fsf@localhost> References: <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org> <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org> <871q9yonl8.fsf@localhost> <87jznqve8g.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 30 23:08:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUwHp-00046s-Np for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jan 2024 23:08:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rUwGu-0003W8-2U; Tue, 30 Jan 2024 17:08:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUwGr-0003Vz-O5 for emacs-devel@gnu.org; Tue, 30 Jan 2024 17:07:57 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUwGm-00084u-0J for emacs-devel@gnu.org; Tue, 30 Jan 2024 17:07:57 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5777A240103 for ; Tue, 30 Jan 2024 23:07:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706652469; bh=memUvDFY2Eip69bUymCmUWESf5Qi6iys3NLx8v6JWt0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=ZRr5omqYDrvcVZtEjNjh3Vqp+tNEIpLufJCshXHiohanrfebcVsaB/0uzJq2B+Fhi 1WCpmVbfSafWC6bkEYuFKn1U5uaqdaPaxSSh/N0vtxB4LCjlqlaKhvRjoIsEcK4vUi LX/v/Dh+kB/CqH8fPZnMwHflEHTCOxa+bmoxSNA0G5YbjK5H9yqCCBHSOqjMgkubGc 3VuC7jhHyMsUC0fzulA9ZmD5Txd8xE9guN1FWFfmZ/scDHi0XSy54lnVMTeI+FbDJe vZcYRt63GEtQ93InwBSkKF+Bm54m9ohjoVjS7DomoFGpY9MwKvEXttM17+ytQC3Brn fFwCPP76cZOng== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TPfRm5GXTz6tvc; Tue, 30 Jan 2024 23:07:48 +0100 (CET) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315644 Archived-At: Stefan Monnier writes: >> I mean an opposite: if `declare-function' is called globally, but the >> actual function is only called by a single function in the file, emit >> warning. > > I see. Not sure it would be very useful: the issue is not "it's only > used here" but "it's only *available* here" (because of the > `require`). Does it mean that you would not recommend moving declare-function inside function if that function does not have require? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at