unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require
Date: Tue, 30 Jan 2024 22:11:14 +0000	[thread overview]
Message-ID: <878r46v5dp.fsf@localhost> (raw)
In-Reply-To: <jwv5xzaa4cw.fsf-monnier+emacs@gnu.org>

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I mean an opposite: if `declare-function' is called globally, but the
>> actual function is only called by a single function in the file, emit
>> warning.
>
> I see.  Not sure it would be very useful: the issue is not "it's only
> used here" but "it's only *available* here" (because of the
> `require`).

Does it mean that you would not recommend moving declare-function inside
function if that function does not have require?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



  reply	other threads:[~2024-01-30 22:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170661605561.6823.12101770977814458206@vcs2.savannah.gnu.org>
     [not found] ` <20240130120056.91DA8C0EFEF@vcs2.savannah.gnu.org>
2024-01-30 12:41   ` [nongnu] elpa/org-contrib eaef050f28: lisp/ox-bibtex.el (org-bibtex-goto-citation): Add missing require Stefan Monnier
2024-01-30 15:19     ` Ihor Radchenko
2024-01-30 17:31       ` Stefan Monnier
2024-01-30 18:59         ` Ihor Radchenko
2024-01-30 21:41           ` Stefan Monnier
2024-01-30 22:11             ` Ihor Radchenko [this message]
2024-01-30 22:57               ` Stefan Monnier
2024-01-31 14:51                 ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r46v5dp.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).