Re: STatus of MPS branch

[Helmut Eller <eller.helmut@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On Sat, Apr 20 2024, Gerd Möllmann wrote:

> There are many things other people could help with at this point. Some
> require no knowledge of MPS, or C. For example:
>
> - Make it work on anything not macOS.

I'm trying to build the igc branch on Debian.  But I get a SIGSEGV when
loaddefs-gen.el gets loaded.

I configured with:
  CFLAGS='-g -O0 -I/scratch/emacs/mps-install/include -L/scratch/emacs/mps-install/lib' configure --enable-checking=yes --without-all --without-x --with-mps=debug

and made some changes to igc.c as seen in the diff below; but those seem
rather innocent.

GCC still emits this warning:

igc.c:229:18: warning: ‘pvec_type’ is narrower than values of its type
  229 |   enum pvec_type pvec_type : IGC_PVEC_BITS;

Is this something to worry about?

Helmut


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: igc.diff --]
[-- Type: text/x-diff, Size: 2117 bytes --]

diff --git a/src/igc.c b/src/igc.c
index dfb25d6c824..5de83980863 100644
--- a/src/igc.c
+++ b/src/igc.c
@@ -73,7 +73,7 @@
 static void
 igc_assert_fail (const char *file, unsigned line, const char *msg)
 {
-  extern void die (const char *, const char *, int);
+  //extern void die (const char *, const char *, int);
   die (msg, file, line);
 }
 
@@ -81,7 +81,7 @@ igc_assert_fail (const char *file, unsigned line, const char *msg)
 # define igc_assert(expr)                         \
    if (!(expr))                                   \
      igc_assert_fail (__FILE__, __LINE__, #expr); \
-   else
+   /* else */
 #else
 # define igc_assert(expr) (void) 9
 #endif
@@ -122,7 +122,7 @@ is_aligned (const mps_addr_t addr)
 #define IGC_CHECK_RES(res) \
   if ((res) != MPS_RES_OK) \
     emacs_abort ();        \
-  else
+  /* else */
 
 #define IGC_WITH_PARKED(gc)                        \
   for (int i = (mps_arena_park (gc->arena), 1); i; \
@@ -801,6 +801,7 @@ scan_pure (mps_ss_t ss, void *start, void *end, void *closure)
   MPS_SCAN_BEGIN (ss)
   {
     igc_assert (start == (void *) pure);
+    extern ptrdiff_t pure_bytes_used_lisp;
     end = (char *) pure + pure_bytes_used_lisp;
     if (end > start)
       IGC_FIX_CALL (ss, scan_ambig (ss, start, end, NULL));
@@ -954,6 +955,7 @@ fix_itree_node (mps_ss_t ss, struct itree_node *n)
 static mps_res_t
 fix_image (mps_ss_t ss, struct image *i)
 {
+#ifdef HAVE_WINDOW_SYSTEM
   MPS_SCAN_BEGIN (ss)
   {
     IGC_FIX12_OBJ (ss, &i->spec);
@@ -964,6 +966,7 @@ fix_image (mps_ss_t ss, struct image *i)
   }
   MPS_SCAN_END (ss);
   return MPS_RES_OK;
+#endif
 }
 
 static mps_res_t
@@ -2342,6 +2345,7 @@ thread_ap (enum igc_obj_type type)
     case IGC_OBJ_FLOAT:
       return t->d.leaf_ap;
     }
+  emacs_abort ();
 }
 
 /* Conditional breakpoints can be so slow that it is often more
@@ -2572,12 +2576,14 @@ igc_make_itree_node (void)
   return n;
 }
 
+#ifdef HAVE_WINDOW_SYSTEM
 struct image *
 igc_make_image (void)
 {
   struct image *img = alloc (sizeof *img, IGC_OBJ_IMAGE, PVEC_FREE);
   return img;
 }
+#endif
 
 struct face *
 igc_make_face (void)

[-- Attachment #3: gdb-session.txt --]
[-- Type: text/plain, Size: 7875 bytes --]

(gdb) r
The program being debugged has been started already.
Start it from the beginning? (y or n) y
`/scratch/emacs/emacs-igc/src/bootstrap-emacs' has changed; re-reading symbols.
Starting program: /scratch/emacs/emacs-igc/src/bootstrap-emacs -batch --no-site-file --no-site-lisp -l ./emacs-lisp/loaddefs-gen.elc -f loaddefs-generate--emacs-batch . ./calc ./calendar ./cedet ./cedet/ede ./cedet/semantic ./cedet/semantic/analyze ./cedet/semantic/bovine ./cedet/semantic/decorate ./cedet/semantic/symref ./cedet/semantic/wisent ./cedet/srecode ./emacs-lisp ./emulation ./erc ./eshell ./gnus ./image ./international ./language ./leim ./leim/quail ./mail ./mh-e ./net ./nxml ./org ./play ./progmodes ./textmodes ./url ./use-package ./vc
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
  INFO     Scraping files for loaddefs... 
  INFO     Scraping files for loaddefs...10% 
  INFO     Scraping files for loaddefs...20% 
  INFO     Scraping files for loaddefs...30% 
  INFO     Scraping files for loaddefs...40% 
  INFO     Scraping files for loaddefs...50% 
  INFO     Scraping files for loaddefs...60% 
  INFO     Scraping files for loaddefs...70% 
  INFO     Scraping files for loaddefs...80% 

Program received signal SIGSEGV, Segmentation fault.

Breakpoint 1, handle_sigsegv (sig=11, 
    siginfo=0x555555f6ed70 <sigsegv_stack+64784>, 
    arg=0x555555f6ec40 <sigsegv_stack+64480>) at sysdep.c:1930
1930      bool fatal = gc_in_progress;
(gdb) xbacktrace 
"help-add-fundoc-usage" (0xe5f03550)
0xe8406ec0 PVEC_COMPILED
0xe8406fd0 PVEC_COMPILED
"loaddefs-generate--make-autoload" (0xe5f03280)
"loaddefs-generate--make-autoload" (0xe5f03200)
"loaddefs-generate--parse-file" (0xe5f03140)
"loaddefs-generate" (0xe5f03048)
"loaddefs-generate--emacs-batch" (0xffffc058)
"funcall" (0xffffc050)
"if" (0xffffc280)
"cond" (0xffffc430)
"let*" (0xffffc630)
"while" (0xffffc800)
"let*" (0xffffca00)
"progn" (0xffffcb70)
"if" (0xffffcce0)
"let" (0xffffcf00)
"let" (0xffffd120)
"command-line-1" (0xffffd2b0)
"let" (0xffffd5e0)
"command-line" (0xffffd770)
"unwind-protect" (0xffffd9e0)
"let" (0xffffdc00)
"if" (0xffffdda0)
"normal-top-level" (0xffffdf30)
(gdb) backtrace 
#0  handle_sigsegv (sig=11, siginfo=0x555555f6ed70 <sigsegv_stack+64784>, 
    arg=0x555555f6ec40 <sigsegv_stack+64480>) at sysdep.c:1930
#1  <signal handler called>
#2  string_intervals (s=XIL(0x7ffff0698edc))
    at /scratch/emacs/emacs-igc/src/lisp.h:4063
#3  0x0000555555767d97 in concat_to_string (nargs=3, args=0x7fffe5f035b8)
    at fns.c:957
#4  0x0000555555767373 in Fconcat (nargs=3, args=0x7fffe5f035b8) at fns.c:746
#5  0x00005555557b466a in exec_byte_code (fun=XIL(0x7fffe64689a5), 
    args_template=257, nargs=1, args=0x7fffe5f03628) at bytecode.c:1229
#6  0x000055555575e1fc in funcall_lambda (fun=XIL(0x7fffe840faad), nargs=0, 
    arg_vector=0x7fffffffc058) at eval.c:3200
#7  0x000055555575d4e7 in funcall_general (fun=XIL(0x7fffe840faad), numargs=0, 
    args=0x7fffffffc058) at eval.c:2982
#8  0x000055555575d7c4 in Ffuncall (nargs=1, args=0x7fffffffc050)
    at eval.c:3032
#9  0x000055555575c088 in eval_sub (form=XIL(0x7fffe7036d63)) at eval.c:2507
#10 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#11 0x0000555555756eae in Fif (args=XIL(0x7fffe7036d33)) at eval.c:395
#12 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7036d23)) at eval.c:2486
#13 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#14 0x0000555555756f45 in Fcond (args=XIL(0x7fffe7031013)) at eval.c:419
#15 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030fe3)) at eval.c:2486
#16 0x0000555555756fcd in Fprogn (body=XIL(0x7fffe7030f43)) at eval.c:439
#17 0x000055555575855c in FletX (args=XIL(0x7fffe7030f03)) at eval.c:979
#18 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030ef3)) at eval.c:2486
#19 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#20 0x0000555555756ffd in prog_ignore (body=XIL(0x7fffe7030ee3)) at eval.c:450
#21 0x00005555557589a6 in Fwhile (args=XIL(0x7fffe7030ed3)) at eval.c:1068
#22 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030ec3)) at eval.c:2486
#23 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#24 0x000055555575855c in FletX (args=XIL(0x7fffe7030e83)) at eval.c:979
#25 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030e73)) at eval.c:2486
#26 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#27 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030e53)) at eval.c:2486
#28 0x0000555555756e8c in Fif (args=XIL(0x7fffe7030e33)) at eval.c:394
#29 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030e23)) at eval.c:2486
#30 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#31 0x000055555575893e in Flet (args=XIL(0x7fffe7030e03)) at eval.c:1047
#32 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7030df3)) at eval.c:2486
#33 0x0000555555756fcd in Fprogn (body=XIL(0x7fffe702ade3)) at eval.c:439
#34 0x000055555575893e in Flet (args=XIL(0x7fffe702adc3)) at eval.c:1047
#35 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe702adb3)) at eval.c:2486
#36 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#37 0x000055555575e607 in funcall_lambda (fun=XIL(0x7fffe702ad53), nargs=1, 
    arg_vector=0x7fffffffd2b0) at eval.c:3283
#38 0x000055555575e004 in apply_lambda (fun=XIL(0x7fffe702ad43), 
    args=XIL(0x7fffe703a6a3), count=...) at eval.c:3154
#39 0x000055555575c735 in eval_sub (form=XIL(0x7fffe703a693)) at eval.c:2625
#40 0x0000555555756fcd in Fprogn (body=XIL(0x7fffe70399d3)) at eval.c:439
#41 0x000055555575893e in Flet (args=XIL(0x7fffe70397e3)) at eval.c:1047
#42 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe70397d3)) at eval.c:2486
#43 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#44 0x000055555575e607 in funcall_lambda (fun=XIL(0x7fffe7039793), nargs=0, 
    arg_vector=0x7fffffffd770) at eval.c:3283
#45 0x000055555575e004 in apply_lambda (fun=XIL(0x7fffe7039783), args=XIL(0), 
    count=...) at eval.c:3154
#46 0x000055555575c735 in eval_sub (form=XIL(0x7fffe70471f3)) at eval.c:2625
#47 0x000055555575907b in Funwind_protect (args=XIL(0x7fffe70462e3))
    at eval.c:1328
#48 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe70462d3)) at eval.c:2486
#49 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#50 0x000055555575893e in Flet (args=XIL(0x7fffe70462b3)) at eval.c:1047
#51 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe70462a3)) at eval.c:2486
#52 0x0000555555756fcd in Fprogn (body=XIL(0x7fffe7045cf3)) at eval.c:439
#53 0x0000555555756eae in Fif (args=XIL(0x7fffe7045b83)) at eval.c:395
#54 0x000055555575beb6 in eval_sub (form=XIL(0x7fffe7045b73)) at eval.c:2486
#55 0x0000555555756fcd in Fprogn (body=XIL(0)) at eval.c:439
#56 0x000055555575e607 in funcall_lambda (fun=XIL(0x7fffe7045b23), nargs=0, 
    arg_vector=0x7fffffffdf30) at eval.c:3283
#57 0x000055555575e004 in apply_lambda (fun=XIL(0x7fffe7045b13), args=XIL(0), 
    count=...) at eval.c:3154
--Type <RET> for more, q to quit, c to continue without paging--
#58 0x000055555575c735 in eval_sub (form=XIL(0x7fffe72674cb)) at eval.c:2625
#59 0x000055555575b931 in Feval (form=XIL(0x7fffe72674cb), lexical=XIL(0x30))
    at eval.c:2396
#60 0x00005555556875aa in top_level_2 () at keyboard.c:1184
#61 0x000055555575991b in internal_condition_case (
    bfun=0x555555687543 <top_level_2>, handlers=XIL(0x90), 
    hfun=0x555555686de8 <cmd_error>) at eval.c:1544
#62 0x0000555555687612 in top_level_1 (ignore=XIL(0)) at keyboard.c:1196
#63 0x0000555555758d5e in internal_catch (tag=XIL(0xe3a0), 
    func=0x5555556875c3 <top_level_1>, arg=XIL(0)) at eval.c:1224
#64 0x000055555568747e in command_loop () at keyboard.c:1145
#65 0x000055555568688a in recursive_edit_1 () at keyboard.c:754
#66 0x0000555555686ab6 in Frecursive_edit () at keyboard.c:837
#67 0x00005555556825d0 in main (argc=41, argv=0x7fffffffe528) at emacs.c:2626
(gdb)