From: Po Lu <luangruo@yahoo.com>
To: Arash Esbati <arash@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers
Date: Wed, 19 Jun 2024 19:18:46 +0800 [thread overview]
Message-ID: <878qz141ux.fsf@yahoo.com> (raw)
In-Reply-To: <m2frt943te.fsf@macmutant.fritz.box> (Arash Esbati's message of "Wed, 19 Jun 2024 12:36:29 +0200")
Arash Esbati <arash@gnu.org> writes:
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit 6aa5068ac71cb1b8e46c299138f99fea44319146
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> Improve treatment of touch screen input by rmc and its callers
>>
>> * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
>> Run touch screen event translation on touch screen events
>> received, and respond to pinch, tap and scrolling gestures.
>>
>> * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in
>> the details window.
>>
>> * lisp/touch-screen.el (touch-screen-translate-touch): Autoload.
>> ---
>> lisp/emacs-lisp/rmc.el | 106 +++++++++++++++++++++++++++++++++----------------
>> lisp/net/nsm.el | 11 ++++-
>> lisp/touch-screen.el | 1 +
>> 3 files changed, 81 insertions(+), 37 deletions(-)
>>
>> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
>> index 378687c0326..883f8bf187f 100644
>> --- a/lisp/emacs-lisp/rmc.el
>> +++ b/lisp/emacs-lisp/rmc.el
>>[...]
>> + (cond
>> + ((null command)) ; Read another event.
>> + ((memq (car-safe command) '(mouse-1 mouse-2))
>> + ;; Display the on-screen keyboard if a tap should be
>> + ;; registered.
>> + (frame-toggle-on-screen-keyboard (selected-frame)
>> + nil))
>> + ;; Respond to scroll and pinch events as if RMC were
>> + ;; not in progress.
>> + ((eq (car-safe command) 'touchscreen-scroll)
>> + (funcall #'touch-screen-scroll command))
>> + ((eq (car-safe command) 'touchscreen-pinch)
>> + (funcall #'touch-screen-pinch command))
>
> I think this part now generates:
>
> In end of data:
> rmc.el:245:32: Warning: the function ‘touch-screen-pinch’ is not known to be defined.
> rmc.el:243:32: Warning: the function ‘touch-screen-scroll’ is not known to be defined.
>
> This on macOS with Emacs from master (e6f4370c).
OK, what if you replace in:
>> + ;; Respond to scroll and pinch events as if RMC were
>> + ;; not in progress.
>> + ((eq (car-safe command) 'touchscreen-scroll)
>> + (funcall #'touch-screen-scroll command))
>> + ((eq (car-safe command) 'touchscreen-pinch)
>> + (funcall #'touch-screen-pinch command))
#'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
and 'touch-screen-pinch?
next prev parent reply other threads:[~2024-06-19 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171861761168.16246.1990246088317606554@vcs2.savannah.gnu.org>
[not found] ` <20240617094652.69EE0C1FB5F@vcs2.savannah.gnu.org>
2024-06-19 10:36 ` master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers Arash Esbati
2024-06-19 11:18 ` Po Lu [this message]
2024-06-19 11:42 ` Arash Esbati
2024-06-27 7:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qz141ux.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=arash@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).