From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.devel Subject: Re: MPS: commit limit Date: Tue, 16 Jul 2024 17:43:17 +0200 Message-ID: <878qy1uyui.fsf@gmail.com> References: <7PXYgVu5A8knQy6Q03cbm6FjO7s022nC0cqCRtUDhQBgA8ZrpLqmoVRgxD8moCTJpB_52ngFaJnW5JIflrzpHe09WcmbRqiHIdWQZE9kQgU=@protonmail.com> <87tth1xm4n.fsf@gmail.com> <87msmtxkpy.fsf@gmail.com> <87ed85xj67.fsf@gmail.com> <8734olxcdj.fsf@gmail.com> <87bk2xweng.fsf@gmail.com> <86r0btgxwj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16846"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, yantar92@posteo.net, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 16 17:44:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sTkLi-0004Ff-4N for ged-emacs-devel@m.gmane-mx.org; Tue, 16 Jul 2024 17:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTkL6-00085o-8O; Tue, 16 Jul 2024 11:43:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTkL5-00085S-4f for emacs-devel@gnu.org; Tue, 16 Jul 2024 11:43:39 -0400 Original-Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sTkKn-0004dY-6Z; Tue, 16 Jul 2024 11:43:38 -0400 Original-Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4266edee10cso36507825e9.2; Tue, 16 Jul 2024 08:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721144598; x=1721749398; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FHkv2nHAiEFUUUz0ZFVNMJSIHYLoDTNCVib2V4m2m4Y=; b=WPkCYieoCR+EVQ2Z/7Gm9kJTdKbOv57Dir1la/9UYi7/ats1/7WSO3BCkIvlJRThFn ZCGnYvojBaX1CPdL+DDaJTKNkl5U/QIYGj/MbxFiumlEtrDVx/z7mVpfOdSWd06bSlXQ Abhh9C5cPirCkq9l3KL7t8QGhfsa/KVbmja60OXiYnt+xdepMctvBZpQq/aaU5xZnuOV LjZlBugrcygDcJtzqvXSDNF95Oc/njGCvtLjFKhEPFumdlBW7ZGSVWcnz+jGAYUC3QO6 J5UROgxun0nQ1D/ik18efx+rkfIgcOI8LlHtWwI/80nrtUDuBs7savpkilOx6cTZ1AqX o3tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721144598; x=1721749398; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FHkv2nHAiEFUUUz0ZFVNMJSIHYLoDTNCVib2V4m2m4Y=; b=cO2C0tuAE9PstOlMnp+RZlgnrt6WkJ4Lr2DBIsgZHK6czvDWFO/zFy60pKsaG0WTve SjtVyd+dMoGCKFuoqC4ZDz0FVgltoH30ZNwV5EA4ZR3/Y8Zjt9E4lXnc6KrM5PHwcrgU FN05+cUIqoOp5SjxbKqsbi3+PrdcH6mEMwWKKmXjELf80DQh5hpKEwRedP9Rpbib8ElV i2OjCTE4l4fho7jJ9KO3cjhKkf/XCD4oOC/dNdK7XjWBKrYmyaLhPzzTYZEa/mSLB+nz R099QlBFwhaOmeoYleLytQwseFYulpVuMVIqtRZ31PRbbxVFlPkFzSKsv1pnlolPWXvn vobQ== X-Forwarded-Encrypted: i=1; AJvYcCVCnNOPtCZ9t42HL9qUHUxqaaH9+DpQ/s9Ba1DiuVJCP/IruH1TI2wKMTWl87Qrq9Nz9UU6rSc6RZ+Lv6pElAJNzSgH X-Gm-Message-State: AOJu0YyOfHbsX/bY3Z3Qehm0Pmtisu6ZxB5laTmLBdZI1wAprfcjT8r3 JKiJP7id47AmTLy0y2pKdZV08IaVsZnGq34ojpWF0aO0qx8heoa8/nYjyg== X-Google-Smtp-Source: AGHT+IFDe4D/yOUUQgjR9GBlG/0fTXPvmCyaGQg9FU5C7bv+fZ9nxGPjdvWjIRiPqTUO2K6NFNi80g== X-Received: by 2002:adf:e80e:0:b0:367:9bc8:8c10 with SMTP id ffacd0b85a97d-36826107477mr2051192f8f.23.1721144598063; Tue, 16 Jul 2024 08:43:18 -0700 (PDT) Original-Received: from caladan (dialin-234199.rol.raiffeisen.net. [195.254.234.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dab3bd8sm9418199f8f.13.2024.07.16.08.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 08:43:17 -0700 (PDT) In-Reply-To: <86r0btgxwj.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 Jul 2024 18:27:24 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321716 Archived-At: On Tue, Jul 16 2024, Eli Zaretskii wrote: >> This patch adds a igc--set-commit-limit function. It doesn't fix the >> problem with the assertion. People who use the hot MPS build will >> probably see a normal memory full error and probably have to quit soon >> after that. The others see the failed assertion and abort immediately. >> So the end result will not be much different. > > Is this a debugging aid? Yes, that too. > If so, please say that in the doc string. It's an internal function. Only people who know what they're doing should use it. > If that's not the reason, then why would we need to limit the amount > of memory MPS can commit? I think we generally let Emacs use as much > memory as the system is prepared to give it, no? It also helps to avoid thrashing on machines that don't have many GB of unused RAM.