From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 2399541: Remove font-lock toggle from font-lock-update Date: Wed, 24 Mar 2021 15:32:26 +0000 Message-ID: <8786a8e8fa731c1bd1ef@heytings.org> References: <20210324143048.23515.75257@vcs0.savannah.gnu.org> <20210324143050.40C6E20D10@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: "Paul W. Rankin" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 24 16:36:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lP5Y8-0009BD-Ia for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 16:36:00 +0100 Original-Received: from localhost ([::1]:36342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP5Y7-0004nY-JO for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 11:35:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP5Ut-0002b1-CC for emacs-devel@gnu.org; Wed, 24 Mar 2021 11:32:39 -0400 Original-Received: from heytings.org ([95.142.160.155]:43668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP5Ul-0001m4-UF for emacs-devel@gnu.org; Wed, 24 Mar 2021 11:32:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1616599946; bh=emvTai1Tc9cp510G4kyoCoYQ4sMBcYAIQUWkFj/8jpo=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Mh9GHIOP0aXjUlcfkTPESgma7Nj6lAMe6ycyr4/Wymz8R8ziJAViQ+5PCeNt7Al5q RqIs+GQIWtA14PV4Txq3VoUhjHt7llLaLHLM5280IaFO9CA8xjVSitZqp1pwWHBezN wYxT9GNVZzqBkcrWM6xmii+VkTh33tgoXtMLBDUWRdDclUS9tjx9YgIhawPxHZWc3E 1LmX5RzabC1HKHJ/Z0ZOHsno5Yq+6c8vc7Mi1RDr+ea/OO1yCwzi7QYc3PKmyXbex8 W1WGswCwEV5HlFdjKuIiBQQY/Mw0roPBf/FR7ySXhtxVYkkLoY2dZ44R4CiaOh4rVH rq5UGX7YSIcow== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266963 Archived-At: * lisp/font-lock.el (font-lock-update): Remove call to font-lock-unfontify-region and font-lock-mode toggle with ARG; this did not perform what original author intended Is this what is supposed to happen? Just forcibly push a change while the discussion is happening, when Stefan told you that your understanding is not right, and when I told you that the command _does_ what "original author" intented? Should I now submit a patch to restore the proper command?