unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Shutko <ats@acm.org>
Subject: appt.el fix: don't use prin1-to-string
Date: Mon, 12 Aug 2002 17:26:47 -0400	[thread overview]
Message-ID: <877kivsr8o.fsf@wesley.springies.com> (raw)

I noticed my appointment popups were looking like:

5:25pm Test" 0 11 (fontified nil)

Cause was appt.el using prin1-to-string for the entries, which had
text properties.  I don't think it shouldn't have ever been using
prin1-to-string, since those _are_ strings to begin with (and it had
code to remove the quotes that prin1-to-string added).  So they're gone.

2002-08-12  Alan Shutko  <ats@acm.org>

	* calendar/appt.el (appt-delete, appt-make-list): Remove
	prin1-to-string calls (and substrings around them).

--- appt.el.~1.44.~	2002-08-12 17:08:41.000000000 -0400
+++ appt.el	2002-08-12 17:14:52.000000000 -0400
@@ -454,9 +454,9 @@
   (let* ((tmp-msg-list appt-time-msg-list))
     (while tmp-msg-list
       (let* ((element (car tmp-msg-list))
-             (prompt-string (concat "Delete " 
-                                    (prin1-to-string (car (cdr element))) 
-                                    " from list? "))
+             (prompt-string (concat "Delete \"" 
+                                    (car (cdr element))
+                                    "\" from list? "))
              (test-input (y-or-n-p prompt-string)))
         (setq tmp-msg-list (cdr tmp-msg-list))
         (if test-input
@@ -512,9 +512,7 @@
 	      (while (and entry-list 
 			  (calendar-date-equal 
 			   (calendar-current-date) (car (car entry-list))))
-		(let ((time-string (substring (prin1-to-string 
-					       (cadr (car entry-list))) 1 -1)))
-
+		(let ((time-string (cadr (car entry-list))))
 		  (while (string-match
 			  "\\([0-9]?[0-9]:[0-9][0-9]\\(am\\|pm\\)?\\).*"
 			  time-string)


-- 
Alan Shutko <ats@acm.org> - In a variety of flavors!
My American Express card left home without me.

             reply	other threads:[~2002-08-12 21:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-12 21:26 Alan Shutko [this message]
2002-08-13 22:46 ` appt.el fix: don't use prin1-to-string Richard Stallman
2002-08-14  0:26   ` Alan Shutko
2002-08-14 14:35     ` Stefan Monnier
2002-08-14 18:44       ` Alan Shutko
2002-08-14 23:13     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877kivsr8o.fsf@wesley.springies.com \
    --to=ats@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).