Re: abort in wait_reading_process_input

[Alex Schroeder <alex@emacswiki.org>]

Hi Kim,

Before installing your patch, I wanted to figure out what triggered
the bug so I would know what to look for.

A week has gone by and the bug has not reappeared


storm@cua.dk (Kim F. Storm) writes:

> Alex Schroeder <alex@emacswiki.org> writes:
>
>> When running ERC, the Emacs IRC Client that is not (yet) part of
>> Emacs, I'm getting an abort in wait_reading_process_input.
>> 
>> Backing out the following change did not help:
>> 
>> revision 1.428
>> date: 2004/05/13 23:07:07;  author: kfstorm;  state: Exp;  lines: +4 -3
>> (wait_reading_process_input): Make reentrant.
>> Make Available and Connecting non-static.  Save and restore value
>> of waiting_for_user_input_p.
>> 
>> Alex.
>> 
>
> Does the following patch help:
>
> *** process.c	14 May 2004 00:42:09 +0200	1.428
> --- process.c	24 May 2004 09:48:17 +0200	
> ***************
> *** 4581,4587 ****
>   		}
>   	    }
>   #ifdef NON_BLOCKING_CONNECT
> ! 	  if (check_connect && FD_ISSET (channel, &Connecting))
>   	    {
>   	      struct Lisp_Process *p;
>   
> --- 4581,4588 ----
>   		}
>   	    }
>   #ifdef NON_BLOCKING_CONNECT
> ! 	  if (check_connect && FD_ISSET (channel, &Connecting)
> ! 	      && FD_ISSET (channel, &connect_wait_mask))
>   	    {
>   	      struct Lisp_Process *p;
>   
>
> -- 
> Kim F. Storm <storm@cua.dk> http://www.cua.dk

-- 
.O.  http://www.emacswiki.org/alex/
..O  Schroeder's fourth law:
OOO  None of your friends and coworkers share your taste in music.