* patch to mailclient + sendmail
@ 2006-04-21 16:32 David Reitter
2006-05-21 15:31 ` Simon Josefsson
2006-05-21 15:55 ` Jason Rumney
0 siblings, 2 replies; 3+ messages in thread
From: David Reitter @ 2006-04-21 16:32 UTC (permalink / raw
This patch to mailclient.el will print an informative message and
improve the short message body that is included by default on Windows
systems.
*** lisp/mail/mailclient.el 22 Feb 2006 19:15:36 +0000 1.4
--- lisp/mail/mailclient.el 21 Apr 2006 17:11:03 +0100
***************
*** 162,172 ****
(progn
(clipboard-kill-ring-save
(+ 1 delimline) (point-max))
! (concat
! "*** E-Mail body has been placed on clipboard, "
! "please paste them here! ***"))
;; else
! (buffer-substring (+ 1 delimline) (point-max))))))))))))
(provide 'mailclient)
--- 162,173 ----
(progn
(clipboard-kill-ring-save
(+ 1 delimline) (point-max))
! "*** E-Mail body has been placed on clipboard, please paste it here!
! Customize `mailclient-place-body-on-clipboard-flag' to avoid this
step. ***")
;; else
! (buffer-substring (+ 1 delimline) (point-max)))))))
! (message
! "Message will be handled by system's default mail client."))))))
(provide 'mailclient)
*** lisp/mail/sendmail.el 21 Apr 2006 17:12:35 +0100 1.302
--- lisp/mail/sendmail.el 21 Apr 2006 17:12:41 +0100
***************
*** 879,885 ****
(cdr (car mail-send-actions)))
(error))
(setq mail-send-actions (cdr mail-send-actions)))
! (message "Sending...done")
;; If buffer has no file, mark it as unmodified and delete auto-
save.
(if (not buffer-file-name)
(progn
--- 879,887 ----
(cdr (car mail-send-actions)))
(error))
(setq mail-send-actions (cdr mail-send-actions)))
! (if (equal (current-message) "Sending...")
! ;; allow send-mail-function to show its own message
! (message "Sending...done"))
;; If buffer has no file, mark it as unmodified and delete auto-
save.
(if (not buffer-file-name)
(progn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: patch to mailclient + sendmail
2006-04-21 16:32 patch to mailclient + sendmail David Reitter
@ 2006-05-21 15:31 ` Simon Josefsson
2006-05-21 15:55 ` Jason Rumney
1 sibling, 0 replies; 3+ messages in thread
From: Simon Josefsson @ 2006-05-21 15:31 UTC (permalink / raw
Cc: Emacs-Devel '
David Reitter <david.reitter@gmail.com> writes:
> This patch to mailclient.el will print an informative message and
> improve the short message body that is included by default on Windows
> systems.
Is it really reliable to assume messages are shown to the user? What
about displaying the information and making it a "Continue (y/n)"
question?
>
>
>
> *** lisp/mail/mailclient.el 22 Feb 2006 19:15:36 +0000 1.4
> --- lisp/mail/mailclient.el 21 Apr 2006 17:11:03 +0100
> ***************
> *** 162,172 ****
> (progn
> (clipboard-kill-ring-save
> (+ 1 delimline) (point-max))
> ! (concat
> ! "*** E-Mail body has been placed on clipboard, "
> ! "please paste them here! ***"))
> ;; else
> ! (buffer-substring (+ 1 delimline) (point-max))))))))))))
>
> (provide 'mailclient)
>
> --- 162,173 ----
> (progn
> (clipboard-kill-ring-save
> (+ 1 delimline) (point-max))
> ! "*** E-Mail body has been placed on clipboard, please paste it here!
> ! Customize `mailclient-place-body-on-clipboard-flag' to avoid this
> step. ***")
> ;; else
> ! (buffer-substring (+ 1 delimline) (point-max)))))))
> ! (message
> ! "Message will be handled by system's default mail client."))))))
>
> (provide 'mailclient)
>
> *** lisp/mail/sendmail.el 21 Apr 2006 17:12:35 +0100 1.302
> --- lisp/mail/sendmail.el 21 Apr 2006 17:12:41 +0100
> ***************
> *** 879,885 ****
> (cdr (car mail-send-actions)))
> (error))
> (setq mail-send-actions (cdr mail-send-actions)))
> ! (message "Sending...done")
> ;; If buffer has no file, mark it as unmodified and delete
> auto-
> save.
> (if (not buffer-file-name)
> (progn
> --- 879,887 ----
> (cdr (car mail-send-actions)))
> (error))
> (setq mail-send-actions (cdr mail-send-actions)))
> ! (if (equal (current-message) "Sending...")
> ! ;; allow send-mail-function to show its own message
> ! (message "Sending...done"))
> ;; If buffer has no file, mark it as unmodified and delete
> auto-
> save.
> (if (not buffer-file-name)
> (progn
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: patch to mailclient + sendmail
2006-04-21 16:32 patch to mailclient + sendmail David Reitter
2006-05-21 15:31 ` Simon Josefsson
@ 2006-05-21 15:55 ` Jason Rumney
1 sibling, 0 replies; 3+ messages in thread
From: Jason Rumney @ 2006-05-21 15:55 UTC (permalink / raw
Cc: Emacs-Devel '
David Reitter <david.reitter@gmail.com> writes:
> This patch to mailclient.el will print an informative message and
> improve the short message body that is included by default on Windows
> systems.
I don't think it is an improvement to mislead users into thinking they
can workaround a limit in the command-line length on Windows by
setting a lisp variable.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-21 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-21 16:32 patch to mailclient + sendmail David Reitter
2006-05-21 15:31 ` Simon Josefsson
2006-05-21 15:55 ` Jason Rumney
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).