From: Chong Yidong <cyd@stupidchicken.com>
Cc: Nick Roberts <nickrob@snap.net.nz>,
Romain Francoise <romain@orebokech.com>,
emacs-devel@gnu.org
Subject: Re: C-g crash redux
Date: Fri, 04 Aug 2006 11:26:18 -0400 [thread overview]
Message-ID: <877j1owmhx.fsf@stupidchicken.com> (raw)
In-Reply-To: <m3y7u4sqjm.fsf@kfs-l.imdomain.dk> (Kim F. Storm's message of "Fri, 04 Aug 2006 13:12:29 +0200")
storm@cua.dk (Kim F. Storm) writes:
>> That's not necessary, since quit_throw_to_read_char calls
>> clear_waiting_for_input, which resets waiting_for_input to 0.
>
> But it doesn't restore waiting_for_user_input_p to its
> previous/original value.
>
> Pls. see the comment about waiting_for_user_input_p in process.c.
Ah, sorry. I got confused between waiting_for_user_input_p and
waiting_for_input.
Nick Roberts <nickrob@snap.net.nz> writes:
> I think that Fsignal should get called (perhaps with QUIT) before
> Emacs gets back to the command loop (or at least before further
> expressions/bytecode is evaluated) so that unbind_to gets called and
> the binding stack stays balanced.
I am hesitant to do this. The code in question looks delicate.
Another approach, which may be less risky, is to protect the portions
of code in read_char where getcjmp is active. We should then be able
to safely use unwind protects inside wait_reading_process_output.
Something like this:
save_getcjmp (save_jump);
restore_getcjmp (local_getcjmp);
timer_start_idle ();
c = kbd_buffer_get_event (&kb, used_mouse_menu, end_time);
restore_getcjmp (save_jump);
-->
count = SPECPDL_INDEX ();
save_getcjmp (save_jump);
restore_getcjmp (local_getcjmp);
timer_start_idle ();
c = kbd_buffer_get_event (&kb, used_mouse_menu, end_time);
restore_getcjmp (save_jump);
unbind_to (count);
What do you think?
next prev parent reply other threads:[~2006-08-04 15:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 20:50 C-g crash redux Romain Francoise
2006-08-02 22:07 ` Nick Roberts
2006-08-02 23:21 ` Kim F. Storm
2006-08-03 2:40 ` Nick Roberts
2006-08-03 15:13 ` Chong Yidong
2006-08-03 22:29 ` Kim F. Storm
2006-08-04 0:32 ` Chong Yidong
2006-08-04 1:49 ` Nick Roberts
2006-08-04 11:12 ` Kim F. Storm
2006-08-04 15:26 ` Chong Yidong [this message]
2006-08-04 16:03 ` Chong Yidong
2006-08-04 20:59 ` Richard Stallman
2006-08-04 22:07 ` Nick Roberts
2006-08-04 23:35 ` Kim F. Storm
2006-08-05 5:45 ` David Kastrup
2006-08-06 18:28 ` Richard Stallman
2006-08-06 20:58 ` Nick Roberts
2006-08-04 0:59 ` Nick Roberts
2006-08-03 4:16 ` Chong Yidong
2006-08-03 5:40 ` Nick Roberts
2006-08-03 7:17 ` Romain Francoise
2006-08-03 7:35 ` Stefan Monnier
2006-08-03 19:15 ` Richard Stallman
2006-08-03 19:14 ` Richard Stallman
2006-08-03 15:50 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877j1owmhx.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).