unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* PATCH: bubbles.el, correct background for empty cells
@ 2007-09-13 13:49 Sascha Wilde
  2007-09-13 14:11 ` Thien-Thi Nguyen
  0 siblings, 1 reply; 2+ messages in thread
From: Sascha Wilde @ 2007-09-13 13:49 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

Hi,

Empty cells in the graphic mode of bubble.el are always white, which
of cause is only correct for a white background.

I attached a small patch, which fixes that.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 766 bytes --]

diff -r 70bcad34282a lisp/play/bubbles.el
--- a/lisp/play/bubbles.el	Tue Sep 11 09:30:57 2007 +0200
+++ b/lisp/play/bubbles.el	Thu Sep 13 15:42:19 2007 +0200
@@ -921,6 +921,7 @@ static char * dot3d_xpm[] = {
   (run-hooks 'bubbles-mode-hook))
 
 ;;;###autoload
+
 (defun bubbles ()
   "Play Bubbles game."
   (interactive)
@@ -1323,7 +1324,7 @@ Return t if new char is non-empty."
       (setq bubbles--empty-image
             (create-image (replace-regexp-in-string
                            "^\"\\(.*\\)\t.*c .*\",$"
-                           "\"\\1\tc #FFFFFF\"," template)
+                           "\"\\1\tc None\"," template)
                           'xpm t
                           ;;:mask 'heuristic
                           :margin '(2 . 1)))


[-- Attachment #3: Type: text/plain, Size: 61 bytes --]


-- 
Sascha Wilde
Life's too short to read boring signatures

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: bubbles.el, correct background for empty cells
  2007-09-13 13:49 PATCH: bubbles.el, correct background for empty cells Sascha Wilde
@ 2007-09-13 14:11 ` Thien-Thi Nguyen
  0 siblings, 0 replies; 2+ messages in thread
From: Thien-Thi Nguyen @ 2007-09-13 14:11 UTC (permalink / raw)
  To: Sascha Wilde; +Cc: emacs-devel

() Sascha Wilde <wilde@sha-bang.de>
() Thu, 13 Sep 2007 15:49:30 +0200

   I attached a small patch, which fixes that.

thanks, installed (but w/o extra newline):

    ;;;###autoload
   +
    (defun bubbles ()

i guess it is a typo.

thi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-13 14:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-13 13:49 PATCH: bubbles.el, correct background for empty cells Sascha Wilde
2007-09-13 14:11 ` Thien-Thi Nguyen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).