unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: "Eric S. Raymond" <esr@thyrsus.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: C-x v v no longer works the way it used to
Date: Sat, 20 Oct 2007 18:56:02 +0200	[thread overview]
Message-ID: <877ilhiv31.fsf@rho.meyering.net> (raw)
In-Reply-To: <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Fri, 19 Oct 2007 16:21:31 -0700")

Dan Nicolaescu <dann@ics.uci.edu> wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>   > > Before the recent vc changes, in a version-controlled directory,
>   > > if I were visiting a non-version-controlled file and hit C-x v v,
>   > > it would effectively add that single file to the version control
>   > > system.  i.e., cvs add, git add, etc.
>   >
>   > > Now, all it does is print "No fileset is available here."
>   >
>   > > Is this intentional?
>   >
>   > It's a bug.
>
> This patch fixes it.
> vc-next-action still has the logic to deal with unregistered files,
> but vc-deduce-fileset would not return one...
> This patch is technically incorrect because it changes
> vc-deduce-fileset to not do what it's docs says it has to do.
> Not sure how the new VC design is supposed to work to fix it
> properly...
>
> Index: vc.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/vc.el,v
> retrieving revision 1.473
> diff -c -3 -p -c -r1.473 vc.el
> *** vc.el  19 Oct 2007 20:59:49 -0000   1.473
> --- vc.el  19 Oct 2007 22:47:56 -0000
> *************** Otherwise, throw an error."
> *** 1283,1288 ****
> --- 1282,1288 ----
>        (message "All version-controlled files below %s selected."
>        		 default-directory)
>        (list default-directory)))
> +   ((not (vc-registered buffer-file-name)) (list buffer-file-name))
>     (t (error "No fileset is available here."))))

Thanks!
Works for me, though I'd rather it not prompt with
"Initial revision level for FILE_NAME: "

BTW, your patch didn't apply, so I applied it manually.

  reply	other threads:[~2007-10-20 16:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 20:51 C-x v v no longer works the way it used to Jim Meyering
2007-10-14 21:01 ` Eric Hanchrow
2007-10-14 22:51   ` Miles Bader
2007-10-15  0:50 ` Stefan Monnier
2007-10-15  2:09   ` Eric S. Raymond
2007-10-19 23:21   ` Dan Nicolaescu
2007-10-20 16:56     ` Jim Meyering [this message]
2007-10-20 21:07     ` Eric S. Raymond
2007-10-21  2:59       ` Dan Nicolaescu
2007-11-12 15:32         ` Dan Nicolaescu
2007-11-13 16:48           ` Dan Nicolaescu
2007-11-14 10:54             ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ilhiv31.fsf@rho.meyering.net \
    --to=jim@meyering.net \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=esr@thyrsus.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).