From: Tassilo Horn <tassilo@member.fsf.org>
To: Juri Linkov <juri@jurta.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: doc-view and mailcap
Date: Mon, 26 Nov 2007 12:16:27 +0100 [thread overview]
Message-ID: <877ik5b6k4.fsf@member.fsf.org> (raw)
In-Reply-To: <v9zlx2q6ma.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Sun, 25 Nov 2007 23:53:49 +0100")
Reiner Steib <reinersteib+gmane@imap.cc> writes:
Hi Reiner,
> Committed:
>
> (defun doc-view-mode-p (type)
> "Return non-nil if image type TYPE is available for `doc-view'.
> Image types are symbols like `dvi', `postscript' or `pdf'."
> (and (display-graphic-p)
> (image-type-available-p 'png)
> (cond
> ((eq type 'dvi)
> (and (doc-view-mode-p 'pdf)
> doc-view-dvipdfm-program
> (executable-find doc-view-dvipdfm-program)))
> ((or (eq type 'postscript) (eq type 'ps)
> (eq type 'pdf))
> (and doc-view-ghostscript-program
> (executable-find doc-view-ghostscript-program)))
> (t ;; unknown image type
> nil))))
Yes, that looks fine. Here's a patch that lets
`doc-view-initiate-display' use the new function.
--8<---------------cut here---------------start------------->8---
2007-11-26 Tassilo Horn <tassilo@member.fsf.org>
* doc-view.el (doc-view-initiate-display): Use `doc-view-mode-p'.
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.24
diff -u -r1.24 doc-view.el
--- lisp/doc-view.el 25 Nov 2007 20:11:47 -0000 1.24
+++ lisp/doc-view.el 26 Nov 2007 11:14:53 -0000
@@ -234,8 +234,12 @@
(defvar doc-view-current-image nil
"Only used internally.")
-(defvar doc-view-current-overlay)
-(defvar doc-view-pending-cache-flush nil)
+
+(defvar doc-view-current-overlay nil
+ "Only used internally.")
+
+(defvar doc-view-pending-cache-flush nil
+ "Only used internally.")
(defvar doc-view-current-info nil
"Only used internally.")
@@ -887,8 +891,7 @@
(defun doc-view-initiate-display ()
;; Switch to image display if possible
- (if (and (display-images-p)
- (image-type-available-p 'png))
+ (if (doc-view-mode-p (intern (file-name-extension buffer-file-name)))
(progn
(doc-view-buffer-message)
(setq doc-view-current-page (or doc-view-current-page 1))
@@ -905,8 +908,9 @@
(message
"%s"
(substitute-command-keys
- (concat "No image (png) support available. Type \\[doc-view-toggle-display] "
- "to switch to an editing mode.")))))
+ (concat "No image (png) support available or some conversion utility for "
+ (file-name-extension buffer-file-name)" files is missing. "
+ "Type \\[doc-view-toggle-display] to switch to an editing mode.")))))
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo
next prev parent reply other threads:[~2007-11-26 11:16 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 9:15 Please install: Some improvements to doc-view.el Tassilo Horn
2007-10-02 13:04 ` Davis Herring
2007-10-02 14:42 ` Tassilo Horn
2007-10-02 16:49 ` Tassilo Horn
2007-10-02 17:33 ` Andreas Schwab
2007-10-02 18:19 ` Tassilo Horn
2007-10-03 18:37 ` Richard Stallman
2007-10-03 23:29 ` Michaël Cadilhac
2007-10-04 7:53 ` Tassilo Horn
2007-10-05 16:13 ` Richard Stallman
2007-10-05 16:43 ` Tassilo Horn
2007-10-06 14:16 ` Tassilo Horn
2007-10-06 23:54 ` Juri Linkov
2007-10-08 15:26 ` Sascha Wilde
2007-10-08 15:51 ` Tassilo Horn
2007-10-08 19:34 ` Juri Linkov
2007-10-09 9:02 ` Tassilo Horn
2007-10-09 21:55 ` Juri Linkov
2007-10-11 1:28 ` Doc-view as default viewer for pdf, ps and dvi files (was: Please install: Some improvements to doc-view.el) Tassilo Horn
2007-10-12 2:46 ` Richard Stallman
2007-10-12 13:09 ` Doc-view as default viewer for pdf, ps and dvi files Tassilo Horn
2007-10-13 0:18 ` Richard Stallman
2007-10-13 8:25 ` Tassilo Horn
2007-10-13 19:48 ` Richard Stallman
2007-10-17 23:34 ` Juri Linkov
2007-10-18 6:47 ` Tassilo Horn
2007-10-18 8:28 ` Tassilo Horn
2007-10-07 13:10 ` Please install: Some improvements to doc-view.el Richard Stallman
2007-10-08 19:42 ` Juri Linkov
2007-10-09 20:03 ` Richard Stallman
2007-10-09 21:30 ` Tassilo Horn
2007-10-15 18:31 ` Richard Stallman
2007-10-15 20:58 ` Tassilo Horn
2007-10-17 23:49 ` Scrolling in doc-view Chong Yidong
2007-10-18 6:27 ` Tassilo Horn
2007-10-18 8:29 ` Tassilo Horn
2007-10-09 21:54 ` Please install: Some improvements to doc-view.el Juri Linkov
2007-10-09 22:17 ` mailcap viewers in dired; gnus-dired.el, mailcap.el (was: Please install: Some improvements to doc-view.el) Reiner Steib
2007-10-09 22:47 ` Juri Linkov
2007-10-10 21:20 ` mailcap viewers in dired; gnus-dired.el, mailcap.el Reiner Steib
2007-10-10 23:43 ` Juri Linkov
2007-10-15 1:37 ` Richard Stallman
2007-10-15 23:46 ` Juri Linkov
2007-10-16 6:49 ` Tassilo Horn
2007-10-18 17:48 ` Lars Magne Ingebrigtsen
2007-10-19 5:40 ` Richard Stallman
2007-10-15 1:37 ` Please install: Some improvements to doc-view.el Richard Stallman
2007-10-15 23:45 ` Juri Linkov
2007-10-16 19:09 ` Richard Stallman
2007-10-16 19:26 ` Leo
2007-10-17 5:03 ` Richard Stallman
2007-10-17 10:15 ` Leo
2007-10-17 20:49 ` Richard Stallman
2007-10-17 21:12 ` Leo
2007-10-19 5:40 ` Richard Stallman
2007-10-17 22:04 ` doc-view and mailcap (was: Please install: Some improvements to doc-view.el) Reiner Steib
2007-10-17 23:35 ` doc-view and mailcap Juri Linkov
2007-10-18 7:31 ` Reiner Steib
2007-11-25 22:53 ` Reiner Steib
2007-11-26 11:16 ` Tassilo Horn [this message]
2007-12-01 18:26 ` Tassilo Horn
2007-12-01 19:50 ` Reiner Steib
2007-12-03 0:33 ` Juri Linkov
2007-12-03 7:41 ` Reiner Steib
2007-12-03 8:18 ` Tassilo Horn
2007-12-03 18:42 ` Richard Stallman
2007-12-03 22:16 ` Tassilo Horn
2007-12-03 22:55 ` Juri Linkov
2007-12-04 9:20 ` Tassilo Horn
2007-12-04 18:22 ` Reiner Steib
2007-12-04 22:45 ` Juri Linkov
2007-12-05 10:08 ` Tassilo Horn
2007-12-05 20:02 ` Reiner Steib
2007-12-05 22:45 ` Juri Linkov
2007-10-16 20:43 ` doc-view and mailcap (was: Please install: Some improvements to doc-view.el) Reiner Steib
2007-10-17 1:16 ` doc-view and mailcap Stefan Monnier
2007-10-17 14:10 ` Richard Stallman
2007-10-17 14:39 ` Stefan Monnier
2007-10-17 16:55 ` Reiner Steib
2007-10-17 23:36 ` Juri Linkov
2007-10-18 5:02 ` Richard Stallman
2007-10-17 5:03 ` doc-view and mailcap (was: Please install: Some improvements to doc-view.el) Richard Stallman
2007-10-17 17:59 ` doc-view and mailcap Reiner Steib
2007-10-17 20:32 ` Tassilo Horn
2007-10-17 21:45 ` Reiner Steib
2007-10-18 4:19 ` Stefan Monnier
2007-10-18 7:33 ` Reiner Steib
2007-10-18 8:24 ` Tassilo Horn
2007-10-18 6:24 ` Tassilo Horn
2007-10-18 20:08 ` Richard Stallman
2007-10-18 20:30 ` Reiner Steib
2007-10-18 21:22 ` Tassilo Horn
2007-10-19 0:42 ` Juri Linkov
2007-10-19 17:42 ` Richard Stallman
2007-10-16 23:52 ` Please install: Some improvements to doc-view.el Juri Linkov
2007-10-06 21:47 ` Stefan Monnier
2007-10-07 13:10 ` Richard Stallman
2007-10-07 0:30 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ik5b6k4.fsf@member.fsf.org \
--to=tassilo@member.fsf.org \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).