From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Michael Albinus <michael.albinus@gmx.de>
Newsgroups: gmane.emacs.devel
Subject: Re: odd code in dbusbind.c
Date: Mon, 31 Dec 2007 11:29:27 +0100
Message-ID: <877iivgnso.fsf@gmx.de>
References: <m3ejd5f7jk.fsf@fleche.redhat.com> <87d4sow4rc.fsf@gmx.de>
	<m3tzlzevvk.fsf@fleche.redhat.com>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: ger.gmane.org 1199096810 13039 80.91.229.12 (31 Dec 2007 10:26:50 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Mon, 31 Dec 2007 10:26:50 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Tom Tromey <tromey@redhat.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 31 11:27:04 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1J9HrI-0001ky-T0
	for ged-emacs-devel@m.gmane.org; Mon, 31 Dec 2007 11:27:01 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1J9Hqx-0005YB-8w
	for ged-emacs-devel@m.gmane.org; Mon, 31 Dec 2007 05:26:39 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J9Hqr-0005Vd-B7
	for emacs-devel@gnu.org; Mon, 31 Dec 2007 05:26:33 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J9Hqp-0005SF-9K
	for emacs-devel@gnu.org; Mon, 31 Dec 2007 05:26:32 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J9Hqp-0005Rx-4h
	for emacs-devel@gnu.org; Mon, 31 Dec 2007 05:26:31 -0500
Original-Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <michael.albinus@gmx.de>) id 1J9Hqo-0004jY-Vc
	for emacs-devel@gnu.org; Mon, 31 Dec 2007 05:26:31 -0500
Original-Received: (qmail invoked by alias); 31 Dec 2007 10:26:29 -0000
Original-Received: from p57A2150B.dip0.t-ipconnect.de (EHLO arthur.local) [87.162.21.11]
	by mail.gmx.net (mp030) with SMTP; 31 Dec 2007 11:26:29 +0100
X-Authenticated: #3708877
X-Provags-ID: V01U2FsdGVkX1848kNdeAk4/ocyW9BNTjjE0WSDRz0KoVEUYtWmP/
	BXbSTrFzBoYBRH
User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux)
X-Y-GMX-Trusted: 0
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:85726
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/85726>

Tom Tromey <tromey@redhat.com> writes:

> Here's one more I ran into -- I was copying parts of dbusbind.c for my
> status icon patch, and this looked odd.  Other places in Emacs seem to
> use non-static input_event structs this way.  kbd_buffer_store_event
> could be clearer about whether the event is copied or the pointer is
> stored, though...

Thanks, I've applied your patch.

> Tom

Best regards, Michael.