From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] support filename prefixes and 100-character filenames in tar-mode.el Date: Thu, 17 Apr 2008 02:17:19 +0300 Organization: JURTA Message-ID: <877iexsavk.fsf@jurta.org> References: <1ea387f60804111051o5e51d86akf34f5d80c4f2fd35@mail.gmail.com> <87od8d33oq.fsf@jurta.org> <1ea387f60804131848g1becbb24o2cb62fd428ae0f5f@mail.gmail.com> <87y77e28ux.fsf@jurta.org> <1ea387f60804151617g5bb966b2t88232b96fada99a9@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208388252 6375 80.91.229.12 (16 Apr 2008 23:24:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Apr 2008 23:24:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: "David Glasser" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 01:24:49 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmGzg-0006m0-MP for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 01:24:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmGz2-0007AY-0B for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2008 19:24:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmGyL-0006sD-CN for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmGyK-0006rc-S9 for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmGyK-0006rV-IC for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:24 -0400 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JmGyK-0003Zk-3j for emacs-devel@gnu.org; Wed, 16 Apr 2008 19:23:24 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JmGyF-000GjB-Ui; Thu, 17 Apr 2008 02:23:20 +0300 In-Reply-To: <1ea387f60804151617g5bb966b2t88232b96fada99a9@mail.gmail.com> (David Glasser's message of "Tue, 15 Apr 2008 16:17:27 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: a8c813420754d5015e2a5a3aeed75c84 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2646 [Apr 16 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95375 Archived-At: >> >> > With all of the patch except for the change in the initial >> >> > initialization of name-end, the results look correct, except the >> >> > penultimate line ends in "foo2" instead of "foo20"; that is because >> >> > the name field here fill the entire field with no nulls, but the code >> >> > previously assumed there would be at least one null. (It's possible >> >> > that similar adjustments are required for the initial values of >> >> > link-end, gname-end, and uname-end.) >> >> >> >> Does your patch also handle @LongLink currently unsupported by tar-mode.el? >> > >> > Is it actually unsupported? When I tried to make a tarball to test >> > this issue with GNU tar, I saw stuff about "@LongLink" when I opened >> > it in tar-mode. (Try making a tarball from the one I sent using GNU >> > tar; you'll see what I mean; I made my test tarball with pax, since >> > that was what was used to make the one I opened when I first noticed >> > this issue.) I don't know if it was correct or not, though. >> >> Please see a test tarball attached below. It is correctly created with >> GNU tar, but opening it in Emacs displays the following message: >> >> Warning: premature EOF parsing tar file >> >> Also its file listing is incomplete, file names are truncated, and content >> of some files is inserted into the file listing in the tar-mode buffer. >> >> I thought your patch will fix these problems. > > Ugh, that's pretty gross. Mine fixes issues with a different way of > encoding long file names, as far as I understand. However, there is > *some* long-link support in tar-mode.el, just not whatever's up with > that file. It seems tar-mode.el has some limitations on the file name lengths. -- Juri Linkov http://www.jurta.org/emacs/