From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Phil Hagelberg Newsgroups: gmane.emacs.devel Subject: Re: Ruby-mode in emacs Date: Mon, 26 May 2008 13:17:46 -0700 Message-ID: <877idgstud.fsf@hagelb.org> References: <878wxxgdu1.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211833125 21716 80.91.229.12 (26 May 2008 20:18:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 May 2008 20:18:45 +0000 (UTC) Cc: zn@mbf.nifty.com, Paul R To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 26 22:19:25 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K0jAC-0003C8-02 for ged-emacs-devel@m.gmane.org; Mon, 26 May 2008 22:19:24 +0200 Original-Received: from localhost ([127.0.0.1]:39120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K0j9Q-0005QD-OQ for ged-emacs-devel@m.gmane.org; Mon, 26 May 2008 16:18:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K0j8k-0004io-9d for emacs-devel@gnu.org; Mon, 26 May 2008 16:17:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K0j8j-0004hN-20 for emacs-devel@gnu.org; Mon, 26 May 2008 16:17:53 -0400 Original-Received: from [199.232.76.173] (port=47326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K0j8i-0004h7-O4 for emacs-devel@gnu.org; Mon, 26 May 2008 16:17:52 -0400 Original-Received: from sd-green-bigip-202.dreamhost.com ([208.97.132.202]:49385 helo=spunkymail-a17.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K0j8i-00085X-Dw for emacs-devel@gnu.org; Mon, 26 May 2008 16:17:52 -0400 Original-Received: from dynabook (dsl081-164-175.sea1.dsl.speakeasy.net [64.81.164.175]) by spunkymail-a17.g.dreamhost.com (Postfix) with ESMTP id E7877751FC; Mon, 26 May 2008 13:17:47 -0700 (PDT) In-Reply-To: <878wxxgdu1.fsf@gmail.com> (Paul R.'s message of "Mon, 26 May 2008 19:44:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97755 Archived-At: Paul R writes: > It is probably a more natural place for an emacs mode than in the ruby > svn, and it would maybe help casual contributors to find their way. Actually, the Ruby developers have already offered it to be included in Emacs: http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00051.html It looks like there are a few things that still need to be done according to Richard: > > To make this program understandable and maintainable, please give > > every defconst and every defun a doc string that explains what jobs > > they do. Large functions such as ruby-calculate-indent need a comment > > to explain every group of lines. Maintaining Emacs is hard already, > > and if we don't want to make it harder, we need to ensure that new > > files are really clear. > > > > It would also be good to add comments at the top of the file > > decribing the features that the mode provides. > > > > (cond > > ((featurep 'font-lock) > > (or (boundp 'font-lock-variable-name-face) > > (setq font-lock-variable-name-face font-lock-type-face)) > > > > (setq ruby-font-lock-syntactic-keywords > > > > Please delete that cond, and put all the contents at top level. I'll see what I can do about documentation. I suppose I should start by submitting patches to the ruby repository until it's ready to go into Emacs. It would make me very happy to get this in by the release of 23. -Phil