unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Phil Hagelberg <phil@hagelb.org>
To: emacs-devel@gnu.org
Cc: zn@mbf.nifty.com, Paul R <paul.r.ml@gmail.com>
Subject: Re: Ruby-mode in emacs
Date: Mon, 26 May 2008 13:17:46 -0700	[thread overview]
Message-ID: <877idgstud.fsf@hagelb.org> (raw)
In-Reply-To: <878wxxgdu1.fsf@gmail.com> (Paul R.'s message of "Mon, 26 May 2008 19:44:22 +0200")

Paul R <paul.r.ml@gmail.com> writes:

> It is probably a more natural place for an emacs mode than in the ruby
> svn, and it would maybe help casual contributors to find their way.

Actually, the Ruby developers have already offered it to be included in
Emacs: http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00051.html
It looks like there are a few things that still need to be done
according to Richard:

> > To make this program understandable and maintainable, please give
> > every defconst and every defun a doc string that explains what jobs
> > they do.  Large functions such as ruby-calculate-indent need a comment
> > to explain every group of lines.  Maintaining Emacs is hard already,
> > and if we don't want to make it harder, we need to ensure that new
> > files are really clear.
> >
> > It would also be good to add comments at the top of the file
> > decribing the features that the mode provides.
> >
> >     (cond
> >      ((featurep 'font-lock)
> >       (or (boundp 'font-lock-variable-name-face)
> >           (setq font-lock-variable-name-face font-lock-type-face))
> >
> >       (setq ruby-font-lock-syntactic-keywords
> >
> > Please delete that cond, and put all the contents at top level.

I'll see what I can do about documentation. I suppose I should start by
submitting patches to the ruby repository until it's ready to go into
Emacs. It would make me very happy to get this in by the release of 23.

-Phil




  reply	other threads:[~2008-05-26 20:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-26 17:44 Ruby-mode in emacs Paul R
2008-05-26 20:17 ` Phil Hagelberg [this message]
2008-05-26 20:30   ` Chong Yidong
2008-05-27  1:45     ` Glenn Morris
2008-05-27  4:56     ` Phil Hagelberg
2008-05-27  7:53       ` Paul R
2008-05-26 20:21 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877idgstud.fsf@hagelb.org \
    --to=phil@hagelb.org \
    --cc=emacs-devel@gnu.org \
    --cc=paul.r.ml@gmail.com \
    --cc=zn@mbf.nifty.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).