Solaris 5.8 version hangs again (X resources for faces?)

Solaris 5.8 version hangs again (X resources for faces?)

[Klaus Zeitler]

In May I reported a problem with the Solaris (5.8) version of emacs 23
(Subject: startup hangs in select call in wait_reading_process_output)
Since then I wasn't able to start emacs 23 up till recently, but last
week I could start emacs again for the first time in weeks.
Unfortunately faces from X resources were not read anymore and 2 days
later I was back to my original problem, i.e. emacs hangs in startup.
It seems as if both my problems have something to do with the following 3
lines in function face-set-after-frame-default in faces.el:

	  ;; X resouces for the default face are applied during
	  ;; x-create-frame.
	  (and (not (eq face 'default))
	       (memq (window-system frame) '(x w32 mac)) 	 
	       (make-face-x-resource-internal face frame))

When I remove these 3 lines from faces.el and rebuild emacs, emacs starts
fine, but my face definitions are gone.

I appreciate any help. Thanks

Klaus

-- 
 --------------------------------------------------
|  Klaus Zeitler      Alcatel-Lucent               |
|  Email:             kzeitler@alcatel-lucent.com  |
 --------------------------------------------------
---
Nichts auf der Welt ist so gerecht verteilt wie der Verstand.  Denn
jedermann ist überzeugt, daß er genug davon habe. -- Rene Descartes

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Chong Yidong]

Klaus Zeitler <kzeitler@alcatel-lucent.com> writes:

> In May I reported a problem with the Solaris (5.8) version of emacs 23
> (Subject: startup hangs in select call in wait_reading_process_output)
> Since then I wasn't able to start emacs 23 up till recently, but last
> week I could start emacs again for the first time in weeks.
> Unfortunately faces from X resources were not read anymore and 2 days
> later I was back to my original problem, i.e. emacs hangs in startup.
> It seems as if both my problems have something to do with the following 3
> lines in function face-set-after-frame-default in faces.el:
>
> 	  ;; X resouces for the default face are applied during
> 	  ;; x-create-frame.
> 	  (and (not (eq face 'default))
> 	       (memq (window-system frame) '(x w32 mac)) 	 
> 	       (make-face-x-resource-internal face frame))
>
> When I remove these 3 lines from faces.el and rebuild emacs, emacs starts
> fine, but my face definitions are gone.
>
> I appreciate any help. Thanks

Could you try to pinpoint where in make-face-x-resource-internal, and
for what face, the hang occurs?

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Klaus Zeitler]

>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
    Chong> 
    Chong> Could you try to pinpoint where in make-face-x-resource-internal, and
    Chong> for what face, the hang occurs?

When I evaluate the function below in scratch buffer with
(face-set-after-frame-default-tst (selected-frame))
I get: Wrong type argument: font, unspecified


(defun face-set-after-frame-default-tst (frame &optional parameters)
  "Initialize the frame-local faces of FRAME.
Calculate the face definitions using the face specs, custom theme
settings, X resources, and `face-new-frame-defaults'.
Finally, apply any relevant face attributes found amongst the
frame parameters in PARAMETERS and `default-frame-alist'."
  (dolist (face (nreverse (face-list)))
    (condition-case ()
	(progn
	  ;; Initialize faces from face spec and custom theme.
	  (face-spec-recalc face frame)
	  ;; X resouces for the default face are applied during
	  ;; x-create-frame.
	  (and (not (eq face 'default))
	       (memq (window-system frame) '(x w32 mac)) 	 
	       (make-face-x-resource-internal face frame))
	  ;; Apply attributes specified by face-new-frame-defaults
	  (internal-merge-in-global-face face frame))
      ;; Don't let invalid specs prevent frame creation.
      (error nil))))


Maybe this helps already. But I can try edebug tomorrow.
BTW the same happens, when I remove my Xresources file.

Thanks for your quick response.

Klaus

-- 
 --------------------------------------------------
|  Klaus Zeitler      Alcatel-Lucent               |
|  Email:             kzeitler@alcatel-lucent.com  |
 --------------------------------------------------
---
The day after tomorrow is the third day of the rest of your life.

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Klaus Zeitler]

>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
    Chong> 
    Chong> Could you try to pinpoint where in make-face-x-resource-internal, and
    Chong> for what face, the hang occurs?

It's the face 'menu' that causes the error.
I've now added a font spec for the menu face and the error is gone, e.g.
Emacs.menu.attributeFont: -b&h-lucidatypewriter-medium-r-normal-sans-17-*-*-*-*-*-iso8859-1

Shouldn't the condition-case take care of the error?
And another question: Shouldn't the window-system check, i.e.
 (memq (window-system frame) '(x w32 mac))
be outside the dolist?

Klaus

-- 
 --------------------------------------------------
|  Klaus Zeitler      Alcatel-Lucent               |
|  Email:             kzeitler@alcatel-lucent.com  |
 --------------------------------------------------
---
It seems like the less a statesman amounts to, the more he loves the flag.

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Chong Yidong]

Klaus Zeitler <kzeitler@alcatel-lucent.com> writes:

>>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
>     Chong> 
>     Chong> Could you try to pinpoint where in make-face-x-resource-internal, and
>     Chong> for what face, the hang occurs?
>
> It's the face 'menu' that causes the error.
> I've now added a font spec for the menu face and the error is gone, e.g.
> Emacs.menu.attributeFont: -b&h-lucidatypewriter-medium-r-normal-sans-17-*-*-*-*-*-iso8859-1

This is strange.  It may be that the face code needs to handle this face
specially.

> Shouldn't the condition-case take care of the error?
> And another question: Shouldn't the window-system check, i.e.
>  (memq (window-system frame) '(x w32 mac))
> be outside the dolist?

No, because face specs and custom face attributes can be defined even in
terminals (X resources, however, cannot).

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Klaus Zeitler]

>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
    Chong> 
    Chong> This is strange.  It may be that the face code needs to
    Chong> handle this face specially.

Will that be taken care of or should I file a bug report?

    >> Shouldn't the condition-case take care of the error?
    >> And another question: Shouldn't the window-system check, i.e.
    >> (memq (window-system frame) '(x w32 mac))
    >> be outside the dolist?
    Chong> 
    Chong> No, because face specs and custom face attributes can be
    Chong> defined even in terminals (X resources, however, cannot).

Not sure we're talking about the same thing. I thought the frame
parameter will not change inside this function (I can't see where it's
going to change).

Klaus


-- 
 --------------------------------------------------
|  Klaus Zeitler      Alcatel-Lucent               |
|  Email:             kzeitler@alcatel-lucent.com  |
 --------------------------------------------------
---
If you cannot convince them, confuse them.  -- Harry S Truman

Re: Solaris 5.8 version hangs again (X resources for faces?)

[Chong Yidong]

Klaus Zeitler <kzeitler@alcatel-lucent.com> writes:

>     >> Shouldn't the condition-case take care of the error?
>     >> And another question: Shouldn't the window-system check, i.e.
>     >> (memq (window-system frame) '(x w32 mac))
>     >> be outside the dolist?
>     Chong> 
>     Chong> No, because face specs and custom face attributes can be
>     Chong> defined even in terminals (X resources, however, cannot).
>
> Not sure we're talking about the same thing. I thought the frame
> parameter will not change inside this function (I can't see where it's
> going to change).

I'm not sure what you mean either.  The memq is for running
make-face-x-resource-internal.  We want to do this for each face (other
than the default face), so that face settings stored in X resources are
obeyed for the new frame.