From: Chong Yidong <cyd@stupidchicken.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
dann@ics.uci.edu, 1133@emacsbugs.donarmstrong.com,
emacs-devel@gnu.org
Subject: Re: Tool-bar and multi-tty
Date: Sat, 11 Oct 2008 15:49:26 -0400 [thread overview]
Message-ID: <877i8edi9l.fsf@cyd.mit.edu> (raw)
In-Reply-To: <jwvbpxrkshx.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Sat, 11 Oct 2008 12:28:06 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> (image-exp `(tool-bar-find-image
>> (if (display-color-p)
>> ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)
>> ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec))))
>
>> Calling tool-bar-local-item-from-menu from the tty loads the lo-spec
>> images, whereas deferring this call until X is started up loads the
>> hi-spec images. But deferring the call, as I suggested, doesn't seem to
>> be satisfactory either.
>
> Why? The `if' is left unevaluated in the image-exp. So IIUC it's only
> be evaluated later when the image is actually displayed.
Aha: the number of display colors is checked earlier in the function.
If we put that check into the image expression instead, everything
works.
I've just checked in a fix into CVS. I think this should resolve the
problems between multi-tty and tool bars.
next prev parent reply other threads:[~2008-10-11 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 2:30 Tool-bar and multi-tty Chong Yidong
2008-10-10 7:50 ` Eli Zaretskii
2008-10-10 7:51 ` Eli Zaretskii
2008-10-10 17:05 ` Chong Yidong
2008-10-10 18:27 ` Eli Zaretskii
2008-10-10 19:43 ` Chong Yidong
2008-10-10 19:51 ` Chong Yidong
2008-10-10 21:32 ` Eli Zaretskii
2008-10-11 16:28 ` Stefan Monnier
2008-10-11 19:49 ` Chong Yidong [this message]
2008-10-12 8:28 ` Andreas Schwab
2008-10-12 8:52 ` Andreas Schwab
2008-10-12 13:51 ` Chong Yidong
2008-10-12 14:31 ` Andreas Schwab
2008-10-12 17:10 ` Chong Yidong
2008-10-10 17:18 ` Stefan Monnier
2008-10-10 18:27 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877i8edi9l.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=1133@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).