unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'martin rudalics' <rudalics@gmx.at>,
	emacs-devel@gnu.org, 'Juanma Barranquero' <lekktu@gmail.com>
Subject: RE: delete-windows-on
Date: Sat, 03 Oct 2009 14:52:52 +0900	[thread overview]
Message-ID: <877hvdhvm3.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <240EE4A03D004CFAA04A4B9AAC3EAD70@us.oracle.com>

Drew Adams writes:
 > Let me summarize the current state of the discussion and my
 > questions/suggestions:

1 & 2 omitted.

 > 3. Emacs 23 always returns nil. Dunno what the case was before
 >    23. I don't have a problem with it always returning nil.
 > 
 > I did suggest that we might instead return something indicating
 > whether a window was actually deleted, similarly to how
 > `kill-buffer' lets you know whether it killed the buffer. But this
 > suggestion is not so important.

My personal preference here is no; code that doesn't accept the
possibility of a dead window error should check window-live-p.  But
the analogy with kill-buffer is appropriate.  So I guess that's a -0.

4 omitted.

 > 5. Raising an error for a string that does not name an existing
 >    buffer is wrong, IMO. No other opinions expressed about this, so far.

AFAICS such a string is a programming error, because (as you've
pointed out yourself) interactively the user must specify an existing
buffer.  Such errors should be raised as early as possible.

If you have a use case, please specify it.  For now, I'm strongly in
favor of raising an error.

 > 6. I suggested that for interactive use the completion candidates
 >    be limited to buffers that actually have windows. No other
 >    opinions expressed about this, so far.

+0.5.  I'm not sure it's worth the programming effort, but I see no
harm in it.





  reply	other threads:[~2009-10-03  5:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-02 16:16 delete-windows-on Drew Adams
2009-10-02 16:30 ` delete-windows-on Juanma Barranquero
2009-10-02 16:47   ` delete-windows-on Drew Adams
2009-10-02 16:51     ` delete-windows-on Juanma Barranquero
2009-10-02 17:25       ` delete-windows-on martin rudalics
2009-10-02 17:55         ` delete-windows-on Drew Adams
2009-10-02 20:31           ` delete-windows-on Drew Adams
2009-10-03  5:52             ` Stephen J. Turnbull [this message]
2009-10-02 17:37       ` delete-windows-on Drew Adams
2009-10-02 18:27         ` delete-windows-on Stephen J. Turnbull
2009-10-02 17:25 ` delete-windows-on martin rudalics
2009-10-02 17:39   ` delete-windows-on Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hvdhvm3.fsf@uwakimon.sk.tsukuba.ac.jp \
    --to=stephen@xemacs.org \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).