From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Kenichi Handa <handa@m17n.org>
Cc: kfogel@red-bean.com, Andreas Schwab <schwab@linux-m68k.org>,
emacs-devel@gnu.org
Subject: Re: GNU Emacs is on Bazaar now.
Date: Mon, 28 Dec 2009 22:51:13 +0900 [thread overview]
Message-ID: <877hs7p5pq.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <tl7skavcofp.fsf@m17n.org>
Kenichi Handa writes:
> For instance, I recently committed these changes in CVS
> (just before it becomes readonly)
>
> 2009-12-25 Kenichi Handa <handa@m17n.org>
>
> * composite.h (composition_adjust_point): Update prototype.
>
> * composite.c (composition_reseat_it): Don't make a composition
> spanning over point.
> (CHAR_COMPOSABLE_P): Treat U+200C (ZWNJ) and U+200D (ZWJ) as
> composable characters.
> (composition_adjust_point): New arg NEW_PT. Callers changed.
>
> * keyboard.c (command_loop_1): Force redisplay if the last point
> was within a composition.
> (adjust_point_for_property): Don't adjust point for automatic
> composition when called after buffer modification.
>
> At that time, each changed file got it's own CVS log because
> I committed each file with C-x v v while supplying its own
> log by using C-c C-a.
>
> Now with bazaar, according to the wiki page, it seems that I
> must commit all files at once with a single log, and thus
> all changed files are given the same log. Is that true?
It's true that all files committed at one time get the same VCS log.
> Is that the right thing?
Yes.
There are alternatives that are closer to your CVS workflow. However,
some involve per-file commits. Those will probably be opposed by many
developers because they will make the VCS logs harder to read and
understand. There are also tools that allow you to manage changes on
a piece by piece basis. Then you finish by grouping them into a
single commit. The disadvantage to those tools is that they will
require additional effort on your part to install and learn them.
If adjusting to this style is really uncomfortable for you, we can
discuss the options.
> If so, is there any convention about the format of the log?
> Can I use a relevant part of ChangeLog file as is?
Reusing the ChangeLog entry is very common in other projects that use
ChangeLogs. A good Emacs ChangeLog entry will generally correspond to
a single commit in Bazaar, so it can be reused for the VCS log for
that commit. As Juanma says, it's very useful to the readers to
provide a one-line summary at the top of each entry.
Eg, the ChangeLog entry quoted above looks like it describes a set of
changes that should constitute a single commit[1], and that log would be
in good style if you add a summary, such as "Improve redisplay and
point handling in character composition".
Footnotes:
[1] The change to CHAR_COMPOSABLE_P might better be split out into a
separate commit, unless that change is needed because of the other
changes.
next prev parent reply other threads:[~2009-12-28 13:51 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-27 22:55 GNU Emacs is on Bazaar now Karl Fogel
2009-12-28 6:46 ` Kenichi Handa
2009-12-28 6:55 ` Karl Fogel
2009-12-28 8:07 ` Kenichi Handa
2009-12-28 8:52 ` Andreas Schwab
2009-12-28 11:41 ` Juanma Barranquero
2009-12-28 11:45 ` Kenichi Handa
2009-12-28 12:08 ` Juanma Barranquero
2009-12-28 13:10 ` Kenichi Handa
2009-12-28 12:09 ` Andreas Schwab
2009-12-28 13:22 ` Xavier Maillard
2009-12-28 13:51 ` Stephen J. Turnbull [this message]
2009-12-28 14:42 ` Juanma Barranquero
2009-12-28 9:19 ` Andreas Schwab
2009-12-28 11:44 ` Juanma Barranquero
2009-12-28 11:47 ` Kenichi Handa
2009-12-28 12:06 ` Andreas Schwab
2009-12-28 13:08 ` Kenichi Handa
2009-12-28 19:59 ` Andreas Schwab
2009-12-28 21:27 ` Karl Fogel
2009-12-28 22:16 ` Andreas Schwab
2009-12-28 22:24 ` Karl Fogel
2009-12-29 1:26 ` Giorgos Keramidas
2009-12-29 2:08 ` Juanma Barranquero
2009-12-29 2:26 ` Giorgos Keramidas
2009-12-28 22:30 ` Óscar Fuentes
2009-12-28 22:41 ` Karl Fogel
2009-12-28 23:14 ` Óscar Fuentes
2009-12-29 1:17 ` Karl Fogel
2009-12-29 2:12 ` Óscar Fuentes
2009-12-29 1:57 ` Stephen J. Turnbull
2009-12-29 2:00 ` Karl Fogel
2009-12-29 2:16 ` Óscar Fuentes
2009-12-29 4:32 ` Stephen J. Turnbull
2009-12-29 4:46 ` Óscar Fuentes
2009-12-29 7:25 ` Kevin Rodgers
2009-12-29 10:27 ` Juanma Barranquero
2009-12-29 15:54 ` Karl Fogel
2009-12-29 16:01 ` Juanma Barranquero
2009-12-29 16:15 ` Óscar Fuentes
2009-12-29 18:08 ` Eli Zaretskii
2009-12-29 18:09 ` Juanma Barranquero
2009-12-29 18:47 ` Eli Zaretskii
2009-12-29 18:13 ` Chong Yidong
2009-12-29 18:36 ` Eli Zaretskii
2009-12-29 18:54 ` Karl Fogel
2009-12-29 20:06 ` Eli Zaretskii
2009-12-29 20:14 ` Karl Fogel
2009-12-31 8:18 ` Stephen J. Turnbull
2009-12-31 8:29 ` Óscar Fuentes
2009-12-31 9:26 ` Miles Bader
2009-12-31 8:44 ` Miles Bader
2010-01-01 8:41 ` Stephen J. Turnbull
2009-12-31 5:57 ` Stephen J. Turnbull
2009-12-31 6:36 ` Óscar Fuentes
2010-01-01 9:21 ` Stephen J. Turnbull
2010-01-01 9:48 ` Óscar Fuentes
2009-12-31 11:33 ` Chong Yidong
2009-12-29 1:47 ` Stephen J. Turnbull
2009-12-29 2:38 ` Óscar Fuentes
2009-12-29 4:38 ` Stephen J. Turnbull
2009-12-29 4:58 ` Óscar Fuentes
2009-12-31 5:54 ` Stephen J. Turnbull
2009-12-31 5:58 ` Miles Bader
2009-12-31 6:02 ` Dan Nicolaescu
2010-01-01 11:22 ` Stephen J. Turnbull
2009-12-31 6:33 ` Óscar Fuentes
2009-12-31 6:51 ` Miles Bader
2010-01-01 10:01 ` Stephen J. Turnbull
2010-01-01 10:19 ` Óscar Fuentes
2009-12-29 6:14 ` Karl Fogel
2009-12-29 7:23 ` Óscar Fuentes
2009-12-28 19:19 ` Eli Zaretskii
2009-12-28 20:00 ` Andreas Schwab
2009-12-28 20:17 ` Eli Zaretskii
2009-12-29 18:00 ` James Cloos
2009-12-29 19:40 ` Óscar Fuentes
2009-12-29 20:02 ` Eli Zaretskii
2009-12-29 20:55 ` James Cloos
2009-12-29 21:30 ` Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hs7p5pq.fsf@uwakimon.sk.tsukuba.ac.jp \
--to=stephen@xemacs.org \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=kfogel@red-bean.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).