From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Pretest compilation problem Date: Wed, 16 Feb 2011 20:40:19 -0500 Message-ID: <877hczsakc.fsf@stupidchicken.com> References: <878vxgjbyn.fsf@stupidchicken.com> <4y7hczeqvq.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297907020 11422 80.91.229.12 (17 Feb 2011 01:43:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Feb 2011 01:43:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 17 02:43:33 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ppsu2-0004Ri-Cs for ged-emacs-devel@m.gmane.org; Thu, 17 Feb 2011 02:43:30 +0100 Original-Received: from localhost ([127.0.0.1]:34834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ppsu2-0006Ec-1w for ged-emacs-devel@m.gmane.org; Wed, 16 Feb 2011 20:43:30 -0500 Original-Received: from [140.186.70.92] (port=42520 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpsrG-0003yg-DX for emacs-devel@gnu.org; Wed, 16 Feb 2011 20:40:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpsrB-0002f5-Dr for emacs-devel@gnu.org; Wed, 16 Feb 2011 20:40:38 -0500 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]:36231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ppsr4-0002cx-5l; Wed, 16 Feb 2011 20:40:26 -0500 Original-Received: from furball (dhcp128036226132.central.yale.edu [128.36.226.132]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1H1eMla026561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 16 Feb 2011 20:40:23 -0500 Original-Received: by furball (Postfix, from userid 1000) id 2A21D1604E2; Wed, 16 Feb 2011 20:40:20 -0500 (EST) In-Reply-To: (Andreas Schwab's message of "Wed, 16 Feb 2011 23:22:48 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.144 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136124 Archived-At: Andreas Schwab writes: > Glenn Morris writes: > >> Chong Yidong wrote: >> >>> Adding $(CFLAGS) sounds correct, >> >> ALL_CFLAGS used to be there in Emacs 23.1. It was removed in r1.461, >> 2009-12-16, by Andreas ("Don't compile prefix-args.c twice.") >> I'm sure he will be happy to provide a detailed explanation. > > Since it's no longer compiling there is no need for CFLAGS any more. Strictly speaking, you're correct. But passing CFLAGS apparently does no harm. As for the statement that -m32 belongs in CC, I doubt that most people make that distinction between -m32 and other arguments to the compiler; at the very least, it is surprising requirement for us to make. Unless anyone can come up with a specific example where adding CFLAGS to this rule causes compilation to do the wrong thing, I'll put it back.