From: Chong Yidong <cyd@stupidchicken.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: emacs-devel@gnu.org
Subject: Re: Pretest compilation problem
Date: Wed, 16 Feb 2011 20:40:19 -0500 [thread overview]
Message-ID: <877hczsakc.fsf@stupidchicken.com> (raw)
In-Reply-To: <m2fwrnzkjr.fsf@igel.home> (Andreas Schwab's message of "Wed, 16 Feb 2011 23:22:48 +0100")
Andreas Schwab <schwab@linux-m68k.org> writes:
> Glenn Morris <rgm@gnu.org> writes:
>
>> Chong Yidong wrote:
>>
>>> Adding $(CFLAGS) sounds correct,
>>
>> ALL_CFLAGS used to be there in Emacs 23.1. It was removed in r1.461,
>> 2009-12-16, by Andreas ("Don't compile prefix-args.c twice.")
>> I'm sure he will be happy to provide a detailed explanation.
>
> Since it's no longer compiling there is no need for CFLAGS any more.
Strictly speaking, you're correct. But passing CFLAGS apparently does
no harm. As for the statement that -m32 belongs in CC, I doubt that
most people make that distinction between -m32 and other arguments to
the compiler; at the very least, it is surprising requirement for us to
make.
Unless anyone can come up with a specific example where adding CFLAGS to
this rule causes compilation to do the wrong thing, I'll put it back.
prev parent reply other threads:[~2011-02-17 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CMM.0.94.0.1297820041.beebe@psi.math.utah.edu>
2011-02-16 14:22 ` Pretest compilation problem Chong Yidong
2011-02-16 15:32 ` Andreas Schwab
2011-02-17 3:16 ` CC, CFLAGS, and -m32 [was Re: Pretest compilation problem] Glenn Morris
2011-02-17 17:28 ` Paul Eggert
2011-02-19 17:39 ` Chong Yidong
2011-02-19 18:14 ` Paul Eggert
2011-02-17 22:57 ` Miles Bader
2011-02-16 19:11 ` Pretest compilation problem Glenn Morris
2011-02-16 22:22 ` Andreas Schwab
2011-02-17 1:40 ` Chong Yidong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hczsakc.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).