From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: lexbind ready for merge Date: Wed, 30 Mar 2011 09:28:57 +0200 Message-ID: <877hbhxe12.fsf@member.fsf.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301470157 3115 80.91.229.12 (30 Mar 2011 07:29:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Mar 2011 07:29:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 30 09:29:13 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4pq4-0004IO-OG for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2011 09:29:13 +0200 Original-Received: from localhost ([127.0.0.1]:53287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4pq2-0000rm-DQ for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2011 03:29:10 -0400 Original-Received: from [140.186.70.92] (port=42934 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4ppu-0000rc-Ls for emacs-devel@gnu.org; Wed, 30 Mar 2011 03:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4pps-0001m5-Fx for emacs-devel@gnu.org; Wed, 30 Mar 2011 03:29:01 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:18249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4pps-0001lj-8V for emacs-devel@gnu.org; Wed, 30 Mar 2011 03:29:00 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id E0CF17817780; Wed, 30 Mar 2011 09:28:58 +0200 (CEST) Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 11630-08; Wed, 30 Mar 2011 09:28:57 +0200 (CEST) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from thinkpad (tsdh.uni-koblenz.de [141.26.67.142]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 61C74781777F; Wed, 30 Mar 2011 09:28:57 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Tue, 29 Mar 2011 17:44:07 -0400") User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.9999 (gnu/linux) X-Virus-Scanned: amavisd-new at uni-koblenz.de X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 141.26.64.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137895 Archived-At: Stefan Monnier writes: > OK, so AFAIK the lexbind branch is pretty much ready for merge. The > only issue is that I'm not sure it has seen as much testing as I'd > like, but then that's largely because it hasn't been merged yet. So > if I don't hear any screams until then, I plan to merge it into trunk > over the week-end or nearby. Please go for it. I'm using it since about a week, and I didn't run on errors (that haven't been solved until now)... ...except that the current git version of Gnus doesn't build with lexbind emacs: --8<---------------cut here---------------start------------->8--- % make cd lisp && make EMACS="emacs" lispdir="/usr/share/emacs/site-lisp/gnus" all make[1]: Entering directory `/home/horn/repos/el/gnus/lisp' rm -f *.elc gnus-load.el auto-autoloads.* custom-load.* URLDIR="/usr/share/emacs/24.0.50/lisp/url/" W3DIR="no" lispdir="/usr/share/emacs/site-lisp/gnus" srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load . Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2) byte-compile-from-buffer(# "foo.el") (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))) (with-current-buffer temp-buffer (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))) (let ((temp-buffer (generate-new-buffer " *temp*"))) (with-current-buffer temp-buffer (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))) (with-temp-buffer (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (let ((outbuf (with-temp-buffer (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")))) (when outbuf (prog1 (with-current-buffer outbuf (goto-char (point-min)) (search-forward " 'foo '(byte-code " nil t)) (kill-buffer outbuf)))) dgnushack-emacs-compile-defcustom-p() (if (dgnushack-emacs-compile-defcustom-p) (progn (maybe-fbind (quote (defined-colors face-attribute))) (maybe-bind (quote (idna-program installation-directory))))) (when (dgnushack-emacs-compile-defcustom-p) (maybe-fbind (quote (defined-colors face-attribute))) (maybe-bind (quote (idna-program installation-directory)))) eval-buffer(# nil "/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t) ; Reading at buffer position 9629 load-with-code-conversion("/home/horn/repos/el/gnus/lisp/dgnushack.el" "/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t) load("/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t) command-line-1(("-l" "./dgnushack.el" "-f" "dgnushack-make-cus-load" ".")) command-line() normal-top-level() make[1]: *** [gnus-load.el] Error 255 make[1]: Leaving directory `/home/horn/repos/el/gnus/lisp' make: *** [lick] Error 2 --8<---------------cut here---------------end--------------->8--- The reason is that in trunk, that function has the signature byte-compile-from-buffer (bytecomp-inbuffer &optional bytecomp-filename) but in the lexbind branch, the optional bytecomp-filename has been removed: byte-compile-from-buffer (inbuffer) AFAIKS, gnus doesn't use the foo.el file anyway, so basically that arg can be removed. But maybe the `byte-compile-from-buffer' definition in [[S]X]Emacs requires exactly 2 arguments? I don't know... Bye, Tassilo