Re: lexbind ready for merge

[Tassilo Horn <tassilo@member.fsf.org>]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> OK, so AFAIK the lexbind branch is pretty much ready for merge.  The
> only issue is that I'm not sure it has seen as much testing as I'd
> like, but then that's largely because it hasn't been merged yet.  So
> if I don't hear any screams until then, I plan to merge it into trunk
> over the week-end or nearby.

Please go for it.  I'm using it since about a week, and I didn't run on
errors (that haven't been solved until now)...

...except that the current git version of Gnus doesn't build with
lexbind emacs:

--8<---------------cut here---------------start------------->8---
% make
cd lisp && make EMACS="emacs" lispdir="/usr/share/emacs/site-lisp/gnus" all
make[1]: Entering directory `/home/horn/repos/el/gnus/lisp'
rm -f *.elc gnus-load.el auto-autoloads.* custom-load.*
URLDIR="/usr/share/emacs/24.0.50/lisp/url/" W3DIR="no" lispdir="/usr/share/emacs/site-lisp/gnus" srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load .
Debugger entered--Lisp error: (wrong-number-of-arguments (1 . 1) 2)
  byte-compile-from-buffer(#<buffer  *temp*> "foo.el")
  (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el"))
  (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (with-current-buffer temp-buffer (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (with-current-buffer temp-buffer (unwind-protect (progn (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  (with-temp-buffer (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el"))
  (let ((outbuf (with-temp-buffer (insert "(defcustom foo (1+ (random)) \"\" :group 'emacs)\n") (byte-compile-from-buffer (current-buffer) "foo.el")))) (when outbuf (prog1 (with-current-buffer outbuf (goto-char (point-min)) (search-forward " 'foo '(byte-code " nil t)) (kill-buffer outbuf))))
  dgnushack-emacs-compile-defcustom-p()
  (if (dgnushack-emacs-compile-defcustom-p) (progn (maybe-fbind (quote (defined-colors face-attribute))) (maybe-bind (quote (idna-program installation-directory)))))
  (when (dgnushack-emacs-compile-defcustom-p) (maybe-fbind (quote (defined-colors face-attribute))) (maybe-bind (quote (idna-program installation-directory))))
  eval-buffer(#<buffer  *load*> nil "/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t)  ; Reading at buffer position 9629
  load-with-code-conversion("/home/horn/repos/el/gnus/lisp/dgnushack.el" "/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t)
  load("/home/horn/repos/el/gnus/lisp/dgnushack.el" nil t)
  command-line-1(("-l" "./dgnushack.el" "-f" "dgnushack-make-cus-load" "."))
  command-line()
  normal-top-level()

make[1]: *** [gnus-load.el] Error 255
make[1]: Leaving directory `/home/horn/repos/el/gnus/lisp'
make: *** [lick] Error 2
--8<---------------cut here---------------end--------------->8---

The reason is that in trunk, that function has the signature

  byte-compile-from-buffer (bytecomp-inbuffer &optional bytecomp-filename)

but in the lexbind branch, the optional bytecomp-filename has been
removed:

  byte-compile-from-buffer (inbuffer)

AFAIKS, gnus doesn't use the foo.el file anyway, so basically that arg
can be removed.  But maybe the `byte-compile-from-buffer' definition in
[[S]X]Emacs requires exactly 2 arguments?  I don't know...

Bye,
Tassilo