From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Wed, 04 May 2011 04:33:01 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <877ha6izea.fsf@lifelogs.com> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <87ipuubao6.fsf@lifelogs.com> <87fwpjfkkz.fsf@lifelogs.com> <87bp072fb1.fsf@lifelogs.com> <874o5vimm5.fsf@lifelogs.com> <87zknjmcyk.fsf@lifelogs.com> <87sjta2zvp.fsf@lifelogs.com> <87liyzglkh.fsf@lifelogs.com> <4DB77682.1070605@gmail.com> <8762q04ba1.fsf@lifelogs.com> <87hb9dufao.fsf@lifelogs.com> <87d3jzc0ct.fsf@lifelogs.com> <878vundy98.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304501606 2162 80.91.229.12 (4 May 2011 09:33:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 May 2011 09:33:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 04 11:33:21 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHYSN-0008LZ-UJ for ged-emacs-devel@m.gmane.org; Wed, 04 May 2011 11:33:20 +0200 Original-Received: from localhost ([::1]:50351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHYSN-00059z-8m for ged-emacs-devel@m.gmane.org; Wed, 04 May 2011 05:33:19 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHYSK-00059i-N9 for emacs-devel@gnu.org; Wed, 04 May 2011 05:33:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHYSJ-0004Ly-Cy for emacs-devel@gnu.org; Wed, 04 May 2011 05:33:16 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:58206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHYSJ-0004Ls-1u for emacs-devel@gnu.org; Wed, 04 May 2011 05:33:15 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QHYSH-0008JP-CJ for emacs-devel@gnu.org; Wed, 04 May 2011 11:33:13 +0200 Original-Received: from c-67-186-102-106.hsd1.il.comcast.net ([67.186.102.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 May 2011 11:33:13 +0200 Original-Received: from tzz by c-67-186-102-106.hsd1.il.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 May 2011 11:33:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-67-186-102-106.hsd1.il.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:qArVglP6MTW+1jPNU2+bRwPAsSA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139101 Archived-At: On Wed, 4 May 2011 05:25:07 +0200 Juanma Barranquero wrote: JB> 2011/5/4 Ted Zlatanov : >> Could you push it into the :dll property of that symbol (always a list)? >> Then just loop on all the names when logging later. JB> What I've done is to add a property :loaded-from to the library-id JB> (the symbol identifying the library). So in case the loading fails, I JB> just log that it failed, but not the filenames that were tried, JB> because they are exactly (cdr (assq 'gnutls dynamic-library-alist)). JB> If the loading is successfull, I log the filename too. That looks great, thanks for fixing it. >> You could just say GNUTLS_LOG2 (1, 1, "loading the GnuTLS DLL: ", >> filename) so it's unconditional (not the end of the world) JB> I've opted for the easiest option, so GNUTLS_LOG2 (1, 1, ...). Feel JB> free to change it once installed. JB> Attached is the third version of the patch. Everything looks OK to me. I'll put some ERT tests on gnutls.el on my TODO list (though anyone should feel free to do it) so we can test a few of the connection cases. Thanks Ted