From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Using glib's g_file_monitor_file and g_file_monitor_directory Date: Wed, 29 May 2013 15:30:57 +0200 Message-ID: <877gihc3qm.fsf@gmx.de> References: <87zjxxn6th.fsf@gmx.de> <87hajqpjn1.fsf@gmx.de> <8738t7pewc.fsf@gmx.de> <83fvx7p1h4.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1369834306 30443 80.91.229.3 (29 May 2013 13:31:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 May 2013 13:31:46 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 29 15:31:45 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UhgTe-0007jQ-Rn for ged-emacs-devel@m.gmane.org; Wed, 29 May 2013 15:31:42 +0200 Original-Received: from localhost ([::1]:33844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgTe-0007Ri-8p for ged-emacs-devel@m.gmane.org; Wed, 29 May 2013 09:31:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgTF-0006je-00 for emacs-devel@gnu.org; Wed, 29 May 2013 09:31:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhgT5-0008M5-EE for emacs-devel@gnu.org; Wed, 29 May 2013 09:31:16 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:63769) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhgT4-0008Lj-Sh for emacs-devel@gnu.org; Wed, 29 May 2013 09:31:07 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.16]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MLlbJ-1UhPDe31Cl-000q93 for ; Wed, 29 May 2013 15:31:05 +0200 Original-Received: (qmail invoked by alias); 29 May 2013 13:31:05 -0000 Original-Received: from p5DCA31B8.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [93.202.49.184] by mail.gmx.net (mp016) with SMTP; 29 May 2013 15:31:05 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/finpvjLTfTqQeWSsSbB5QRuaARYxr+5uy63FWym rNB6EmSaP3/Fmz In-Reply-To: <83fvx7p1h4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 May 2013 18:29:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159882 Archived-At: Eli Zaretskii writes: > I'd rather not special-case w32 unless really necessary. (The whole > point of using the Posix configury was to remove as much w32-specific > stuff as possible from the build process.) So yes, let's by all means > support "no" for w32, although I'm not sure who'd want that. And > please also include mingw32 in the same test harness where you test > for gfilenotify and inotify, i.e. test for a header (windows.h will > do), not the value of $opsys. Done. > Btw, glib is available for Windows as well, and AFAICT its > gfilemonitor should work (it actually uses the same APIs as > w32notify.c does). So "gfile" should not be precluded from the w32 > build. OK. > See above: I'd prefer this to be a real test, based on windows.h > presence. And if the user selected "gfile", let them have it, do not > override with w32notify.o. Also done. >> +#if defined (HAVE_GFILENOTIFY) || defined (HAVE_INOTIFY) || defined (HAVE_NTGUI) > > It sounds like a single symbol HAVE_FILE_NOTIFY, defined somewhere as > the OR of these 3, should make the sources more readable. That's now USE_FILE_NOTIFY. I will wait another couple of days (let's say until Sunday evening), if there's no objection I will commit. I cannot test the MS Windows case; here I trust on you. Best regards, Michael.